-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update end-to-end test server to implement resource detection scenario #396
Update end-to-end test server to implement resource detection scenario #396
Conversation
0138252
to
d5bfdbf
Compare
25e3300
to
0be53ab
Compare
@aabmass where is "local" actually being run? It seems to be on GCP somewhere, as the metadata server is available, but it doesn't appear to be on GCE, since machine-type isn't being found as an attribute. |
It just connects to the local docker daemon, so in CI it's running on Cloud Build. We are also setting the network so that the inner container can get ADC
See https://cloud.google.com/build/docs/build-config-file-schema#network. |
55de392
to
dfda8af
Compare
I ended up adding a function to detect when we are on GCE. That should help filter out other platforms (like cloud build) that we haven't implemented detection for. |
All passing now! |
…if zone isn't found
dfda8af
to
44bff03
Compare
This PR:
The e2e test below passes the resourceDetection scenario.