Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SDK ExponentialHistogram unit test and check for errors from other metric types #822

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Add SDK ExponentialHistogram unit test and check for errors from other metric types #822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 77 additions & 3 deletions exporter/metric/metric_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,17 @@ func TestExportMetrics(t *testing.T) {
metric.WithResource(res),
)

//nolint:errcheck
defer func() {
err = provider.Shutdown(ctx)
assert.NoError(t, err)
}()

meter := provider.Meter("test")
counter, err := meter.Int64Counter("name.lastvalue")
require.NoError(t, err)

counter.Add(ctx, 1)
require.NoError(t, provider.Shutdown(ctx))
}

func TestExportCounter(t *testing.T) {
Expand Down Expand Up @@ -119,7 +124,10 @@ func TestExportCounter(t *testing.T) {

ctx := context.Background()
//nolint:errcheck
defer provider.Shutdown(ctx)
defer func() {
err = provider.Shutdown(ctx)
assert.NoError(t, err)
}()

// Start meter
meter := provider.Meter("cloudmonitoring/test")
Expand Down Expand Up @@ -163,7 +171,10 @@ func TestExportHistogram(t *testing.T) {

ctx := context.Background()
//nolint:errcheck
defer provider.Shutdown(ctx)
defer func() {
err = provider.Shutdown(ctx)
assert.NoError(t, err)
}()

// Start meter
meter := provider.Meter("cloudmonitoring/test")
Expand All @@ -177,6 +188,69 @@ func TestExportHistogram(t *testing.T) {
counter.Record(ctx, 200, otelmetric.WithAttributes(clabels...))
}

func TestExportExponentialHistogram(t *testing.T) {
testServer, err := cloudmock.NewMetricTestServer()
//nolint:errcheck
go testServer.Serve()
defer testServer.Shutdown()
assert.NoError(t, err)

clientOpts := []option.ClientOption{
option.WithEndpoint(testServer.Endpoint),
option.WithoutAuthentication(),
option.WithGRPCDialOption(grpc.WithTransportCredentials(insecure.NewCredentials())),
}

exporter, err := New(
WithProjectID("PROJECT_ID_NOT_REAL"),
WithMonitoringClientOptions(clientOpts...),
WithMetricDescriptorTypeFormatter(formatter),
)
assert.NoError(t, err)

view := metric.NewView(
metric.Instrument{
Name: "counter-a",
Scope: instrumentation.Scope{Name: "cloudmonitoring/test"},
},
metric.Stream{
Aggregation: metric.AggregationBase2ExponentialHistogram{
MaxSize: 160,
MaxScale: 20,
},
},
)

provider := metric.NewMeterProvider(
metric.WithReader(metric.NewPeriodicReader(exporter)),
metric.WithView(view),
metric.WithResource(
resource.NewWithAttributes(
semconv.SchemaURL,
attribute.String("test_id", "abc123"),
),
),
)
assert.NoError(t, err)

ctx := context.Background()
//nolint:errcheck
defer func() {
err = provider.Shutdown(ctx)
assert.NoError(t, err)
}()

// Start meter
meter := provider.Meter("cloudmonitoring/test")

counter, err := meter.Int64Histogram("counter-a")
assert.NoError(t, err)
clabels := []attribute.KeyValue{attribute.Key("key").String("value")}
counter.Record(ctx, 100, otelmetric.WithAttributes(clabels...))
counter.Record(ctx, 50, otelmetric.WithAttributes(clabels...))
counter.Record(ctx, 200, otelmetric.WithAttributes(clabels...))
}

func TestDescToMetricType(t *testing.T) {
inMe := []*metricExporter{
{
Expand Down
Loading