Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the prometheus.type metric metadata to support double-writing unknown-typed metrics #839

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Apr 23, 2024

Depends on open-telemetry/opentelemetry-collector-contrib#32605

This removes the gcp.untypedDoubleExport feature gate, as it is no longer needed.

Specification

From https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/prometheus_and_openmetrics.md#gauges-1

An OpenTelemetry Gauge MUST be converted to a Prometheus Unknown-typed metric if the prometheus.type key of metric.metadata is unknown. Otherwise, it MUST be converted to a Prometheus Gauge.

@dashpole dashpole requested a review from a team as a code owner April 23, 2024 18:26
@dashpole
Copy link
Contributor Author

cc @ridwanmsharif

@dashpole
Copy link
Contributor Author

dashpole commented Apr 23, 2024

@dashpole
Copy link
Contributor Author

I pinned the pdata dependency only in the integration test module (so it doesn't affect the released modules) to include open-telemetry/opentelemetry-collector#10026. This makes sure the fixture-based tests continue to work correctly.

@dashpole dashpole marked this pull request as ready for review April 26, 2024 14:14
@dashpole
Copy link
Contributor Author

This is ready for review now

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.37%. Comparing base (4caace7) to head (99ac427).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #839      +/-   ##
==========================================
+ Coverage   61.03%   62.37%   +1.33%     
==========================================
  Files          56       57       +1     
  Lines        5903     4901    -1002     
==========================================
- Hits         3603     3057     -546     
+ Misses       2143     1687     -456     
  Partials      157      157              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ridwanmsharif ridwanmsharif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woooo! So happy we can unfork now

@dashpole dashpole merged commit 43f7095 into GoogleCloudPlatform:main Apr 29, 2024
27 checks passed
@dashpole dashpole deleted the gmp_unknown branch April 29, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants