-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the prometheus.type metric metadata to support double-writing unknown-typed metrics #839
Conversation
|
I pinned the pdata dependency only in the integration test module (so it doesn't affect the released modules) to include open-telemetry/opentelemetry-collector#10026. This makes sure the fixture-based tests continue to work correctly. |
This is ready for review now |
…nown-typed metrics
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #839 +/- ##
==========================================
+ Coverage 61.03% 62.37% +1.33%
==========================================
Files 56 57 +1
Lines 5903 4901 -1002
==========================================
- Hits 3603 3057 -546
+ Misses 2143 1687 -456
Partials 157 157 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woooo! So happy we can unfork now
Depends on open-telemetry/opentelemetry-collector-contrib#32605
This removes the
gcp.untypedDoubleExport
feature gate, as it is no longer needed.Specification
From https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/prometheus_and_openmetrics.md#gauges-1