Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded Auth Extension files #842

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

damemi
Copy link
Contributor

@damemi damemi commented Apr 29, 2024

Now that the GCP auth extension is available in collector-contrib we don't need some of this code:

  • Removes testdata/config.yaml and config_test.go (duplicated [upstream[(https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/extension/googleclientauthextension/config_test.go))
  • Removes README steps about building into a custom collector
  • Removes internal/metadata/status.go as it is duplicated upstream

@damemi damemi requested a review from a team as a code owner April 29, 2024 17:48
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.34%. Comparing base (4caace7) to head (c600631).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
+ Coverage   61.03%   62.34%   +1.30%     
==========================================
  Files          56       57       +1     
  Lines        5903     4894    -1009     
==========================================
- Hits         3603     3051     -552     
+ Misses       2143     1686     -457     
  Partials      157      157              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

extension/googleclientauthextension/factory_test.go Outdated Show resolved Hide resolved
extension/googleclientauthextension/factory_test.go Outdated Show resolved Hide resolved
extension/googleclientauthextension/factory_test.go Outdated Show resolved Hide resolved
extension/googleclientauthextension/factory_test.go Outdated Show resolved Hide resolved
extension/googleclientauthextension/factory_test.go Outdated Show resolved Hide resolved
extension/googleclientauthextension/factory_test.go Outdated Show resolved Hide resolved
@damemi damemi merged commit bda7f02 into GoogleCloudPlatform:main Apr 30, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants