Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: drop support for node 10 and 12 #477

Merged
merged 1 commit into from
Jan 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,10 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [10, 12, 14, 16]
node: [14, 16, 18, 19]
include:
# use latest npm by default
- npm-version: latest
# overrides for node 10 and 12
- node: 10
npm-version: ^7
- node: 12
npm-version: ^8
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
Expand All @@ -30,15 +25,15 @@ jobs:
- run: npx lerna bootstrap --no-ci
- run: npm test
- run: npm run codecov
if: matrix.node == 14
if: matrix.node == 19

lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 15
node-version: 19
- run: npm install
- run: npm run lint

Expand All @@ -51,9 +46,9 @@ jobs:
for f in $(git ls-files "**package-lock.json")
do
lockfileVersion=$(jq ".lockfileVersion" $f)
if [ $lockfileVersion -ne 2 ]
if [ $lockfileVersion -lt 2 ]
then
>&2 echo "package-lock.json files should have lockfileVersion 2, but $f has version $lockfileVersion"
>&2 echo "package-lock.json files should have at least lockfileVersion 2, but $f has version $lockfileVersion"
exit 1
fi
done
2 changes: 1 addition & 1 deletion e2e-test-server/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion e2e-test-server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"license": "Apache-2.0",
"keywords": [],
"engines": {
"node": ">=10"
"node": ">=14"
},
"scripts": {
"lint": "gts lint",
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"author": "Google Inc.",
"license": "Apache-2.0",
"engines": {
"node": ">=10"
"node": ">=14"
},
"devDependencies": {
"lerna": "4.0.0"
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"author": "Google Inc.",
"license": "Apache-2.0",
"engines": {
"node": ">=10"
"node": ">=14"
},
"files": [
"build/src/**/*.js",
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/opentelemetry-cloud-trace-exporter/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"author": "Google Inc.",
"license": "Apache-2.0",
"engines": {
"node": ">=10"
"node": ">=14"
},
"files": [
"build/src/**/*.js",
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"author": "Google Inc.",
"license": "Apache-2.0",
"engines": {
"node": ">=10"
"node": ">=14"
},
"files": [
"build/src/**/*.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/opentelemetry-resource-util/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/opentelemetry-resource-util/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"author": "Google Inc.",
"license": "Apache-2.0",
"engines": {
"node": ">=10"
"node": ">=14"
},
"files": [
"build/src/**/*.js",
Expand Down
2 changes: 1 addition & 1 deletion samples/trace/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion samples/trace/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"start": "node ./index.js"
},
"engines": {
"node": ">=10"
"node": ">=14"
},
"repository": "GoogleCloudPlatform/opentelemetry-operations-js",
"dependencies": {
Expand Down