Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind the gerrit service account to a GCP one #204

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

fejta
Copy link
Contributor

@fejta fejta commented Jan 7, 2020

ref #202

/assign @Katharine @chases2

test-infra$ experiment/workload-identity/enable-workload-identity.sh oss-prow us-west1-a prow
++ gcloud beta container clusters describe prow '--format=value(workloadIdentityConfig.identityNamespace)' --project=oss-prow --zone=us-west1-a
++ gcloud beta container node-pools list --cluster=prow '--format=value(name,config.workloadMetadataConfig.nodeMetadata)' --project=oss-prow --zone=us-west1-a
Nothing to do

After merging I can run:

test-infra$ experiment/workload-identity/bind-service-accounts.sh oss-prow us-west1-a prow default gerrit [email protected]
Service account has wrong/missing annotation, please declare the following to default/gerrit in gke_oss-prow_us-west1-a_prow:
{"metadata": {"annotations": "iam.gke.io/gcp-service-account": "$gcp_service_account"}}

@fejta
Copy link
Contributor Author

fejta commented Jan 8, 2020

Can I get a review here?

@google-oss-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clarketm, fejta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 3348f50 into GoogleCloudPlatform:master Jan 8, 2020
@fejta fejta deleted the up branch January 8, 2020 23:28
@fejta fejta mentioned this pull request Jan 8, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants