Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use workload identity for esp-v2 jobs #247

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

fejta
Copy link
Contributor

@fejta fejta commented Jan 17, 2020

ref #202 #222

An owner of [email protected] will need to run the following first:

 gcloud iam service-accounts add-iam-policy-binding \
      "--project=cloudesf-testing" \
      --role=roles/iam.workloadIdentityUser \
      "--member=serviceAccount:oss-prow.svc.id.goog[test-pods/gcp-esp-v2-default]" \
      [email protected]

/assign @TAOXUY @hopkiw

@google-oss-robot
Copy link
Collaborator

@fejta: GitHub didn't allow me to assign the following users: TAOXUY.

Note that only GoogleCloudPlatform members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

ref #202 #222

An owner of [email protected] will need to run the following first:

gcloud iam service-accounts add-iam-policy-binding \
     "--project=cloudesf-testing" \
     --role=roles/iam.workloadIdentityUser \
     "--member=serviceAccount:oss-prow.svc.id.goog[test-pods/gcp-esp-v2-default]" \
     [email protected]

/assign @TAOXUY @hopkiw

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, TAOXUY

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link
Collaborator

@TAOXUY: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta fejta added the lgtm label Jan 17, 2020
@google-oss-robot google-oss-robot merged commit ba6a3e4 into GoogleCloudPlatform:master Jan 17, 2020
@google-oss-robot
Copy link
Collaborator

@fejta: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key esp-v2.yaml using file prow/prowjobs/GoogleCloudPlatform/esp-v2/esp-v2.yaml

In response to this:

ref #202 #222

An owner of [email protected] will need to run the following first:

gcloud iam service-accounts add-iam-policy-binding \
     "--project=cloudesf-testing" \
     --role=roles/iam.workloadIdentityUser \
     "--member=serviceAccount:oss-prow.svc.id.goog[test-pods/gcp-esp-v2-default]" \
     [email protected]

/assign @TAOXUY @hopkiw

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta fejta deleted the deploy branch January 17, 2020 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants