Skip to content

Commit

Permalink
Merge pull request #1209 from andrewsg/flake8
Browse files Browse the repository at this point in the history
Ignore Flake8 import order error I202 to accommodate region tags
  • Loading branch information
andrewsg authored Nov 9, 2017
2 parents 9c54bb2 + 05861e4 commit 01fc1d5
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
1 change: 1 addition & 0 deletions iot/api-client/manager/manager_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

from google.cloud import pubsub
import pytest

import manager

cloud_region = 'us-central1'
Expand Down
1 change: 0 additions & 1 deletion language/cloud-client/v1/snippets.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
from google.cloud import language
from google.cloud.language import enums
from google.cloud.language import types

import six


Expand Down
5 changes: 5 additions & 0 deletions nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,15 @@ def _setup_appengine_sdk(session):

PYTEST_COMMON_ARGS = []

# Ignore I202 "Additional newline in a section of imports." to accommodate
# region tags in import blocks. Since we specify an explicit ignore, we also
# have to explicitly ignore the list of default ignores:
# `E121,E123,E126,E226,E24,E704,W503,W504` as shown by `flake8 --help`.
FLAKE8_COMMON_ARGS = [
'--show-source', '--builtin', 'gettext', '--max-complexity', '20',
'--import-order-style', 'google',
'--exclude', '.nox,.cache,env,lib,generated_pb2,*_pb2.py,*_pb2_grpc.py',
'--ignore=E121,E123,E126,E226,E24,E704,W503,W504,I202',
]


Expand Down

0 comments on commit 01fc1d5

Please sign in to comment.