insertId is within the row, not the request.

Fixes bug #134
GoogleCloudPlatform · Oct 29, 2015 · fd1cc21 · fd1cc21
1 parent 1ff6a5b
commit fd1cc21
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/bigquery/api/streaming.py b/bigquery/api/streaming.py
@@ -35,11 +35,13 @@
 # [START stream_row_to_bigquery]
 def stream_row_to_bigquery(bigquery, project_id, dataset_id, table_name, row,
                            num_retries=5):
-    # Generate a unique row id so retries
-    # don't accidentally duplicate insert
     insert_all_data = {
-        'insertId': str(uuid.uuid4()),
-        'rows': [{'json': row}]
+        'rows': [{
+            'json': row,
+            # Generate a unique id for each row so retries don't accidentally
+            # duplicate insert
+            'insertId': str(uuid.uuid4()),
+        }]
     }
     return bigquery.tabledata().insertAll(
         projectId=project_id,

diff --git a/bigquery/api/streaming_test.py b/bigquery/api/streaming_test.py
@@ -40,5 +40,6 @@ def test_stream_row_to_bigquery(self):
                 self.table_id,
                 num_retries=5)
 
+        print stdout
         results = stdout.getvalue().split('\n')
         self.assertIsNotNone(json.loads(results[0]))