KMS: Make the encrypt/decrypt samples consistent with the other languages #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
theacodes
suggested changes
Aug 16, 2017
kms/api-client/snippets.py
Outdated
| cryptokeys = kms_client.projects().locations().keyRings().cryptoKeys() | ||
| request = cryptokeys.encrypt( | ||
| # Use the KMS API to encrypt the data. | ||
| cryptoKeys = kms_client.projects().locations().keyRings().cryptoKeys() |
There was a problem hiding this comment.
our Python style guide is lower snake case for variable names. I understand the desire to match the API, but we've stuck to using lower snake case consistency for variables regardless of the API.
There was a problem hiding this comment.
Fixed. Sorry, I didn't intend to go against the style guide, just an oversight on my part.
| """Encrypts data from a plaintext_file_name using the provided CryptoKey | ||
| and saves it to an encrypted_file_name so it can only be recovered with a | ||
| call to decrypt.""" | ||
| def encrypt(project_id, location_id, key_ring_id, crypto_key_id, |
There was a problem hiding this comment.
Since you are changing variable names, can you update the other samples in this file to match?
In particular, this change:
- changes to use a consistent "_id" suffix for resource name components
- uses "data" instead of "text", since encryption is not restricted to text
- substitutes "ciphertext" for "encrypted {text, data}"
- spells "crypto key" and "key ring" each as two separate words, as in the API
Tracking bug: http://b/64758639
theacodes
approved these changes
Aug 17, 2017
busunkim96
pushed a commit
to googleapis/python-kms
that referenced
this pull request
Jun 4, 2020
…oogleCloudPlatform/python-docs-samples#1075) In particular, this change: - changes to use a consistent "_id" suffix for resource name components - uses "data" instead of "text", since encryption is not restricted to text - substitutes "ciphertext" for "encrypted {text, data}" - spells "crypto key" and "key ring" each as two separate words, as in the API Tracking bug: http://b/64758639
rsamborski
pushed a commit
that referenced
this pull request
Nov 8, 2022
…1075) In particular, this change: - changes to use a consistent "_id" suffix for resource name components - uses "data" instead of "text", since encryption is not restricted to text - substitutes "ciphertext" for "encrypted {text, data}" - spells "crypto key" and "key ring" each as two separate words, as in the API Tracking bug: http://b/64758639
8 tasks
rsamborski
pushed a commit
that referenced
this pull request
Nov 8, 2022
…1075) In particular, this change: - changes to use a consistent "_id" suffix for resource name components - uses "data" instead of "text", since encryption is not restricted to text - substitutes "ciphertext" for "encrypted {text, data}" - spells "crypto key" and "key ring" each as two separate words, as in the API Tracking bug: http://b/64758639
rsamborski
pushed a commit
that referenced
this pull request
Nov 11, 2022
…1075) In particular, this change: - changes to use a consistent "_id" suffix for resource name components - uses "data" instead of "text", since encryption is not restricted to text - substitutes "ciphertext" for "encrypted {text, data}" - spells "crypto key" and "key ring" each as two separate words, as in the API Tracking bug: http://b/64758639
rsamborski
pushed a commit
that referenced
this pull request
Nov 14, 2022
…1075) In particular, this change: - changes to use a consistent "_id" suffix for resource name components - uses "data" instead of "text", since encryption is not restricted to text - substitutes "ciphertext" for "encrypted {text, data}" - spells "crypto key" and "key ring" each as two separate words, as in the API Tracking bug: http://b/64758639
dandhlee
pushed a commit
that referenced
this pull request
Nov 14, 2022
…1075) In particular, this change: - changes to use a consistent "_id" suffix for resource name components - uses "data" instead of "text", since encryption is not restricted to text - substitutes "ciphertext" for "encrypted {text, data}" - spells "crypto key" and "key ring" each as two separate words, as in the API Tracking bug: http://b/64758639
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Oct 21, 2023
…oogleCloudPlatform/python-docs-samples#1075) In particular, this change: - changes to use a consistent "_id" suffix for resource name components - uses "data" instead of "text", since encryption is not restricted to text - substitutes "ciphertext" for "encrypted {text, data}" - spells "crypto key" and "key ring" each as two separate words, as in the API Tracking bug: http://b/64758639
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, this change:
Tracking bug: http://b/64758639