update to use v1 client #1216
Merged
update to use v1 client #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
theacodes
reviewed
Nov 13, 2017
| @@ -90,7 +87,7 @@ def index(path, index_file): | |||
| print('Failed to process {}'.format(file_path)) | |||
|
|
|||
| with io.open(index_file, 'w', encoding='utf-8') as f: | |||
| f.write(json.dumps(result)) | |||
| f.write(unicode(json.dumps(result))) | |||
There was a problem hiding this comment.
unicode doesn't exist on python 3, what you really want here is:
json.dump(result, f)
There was a problem hiding this comment.
python 2.7's json.dump seems to use f.write and json.dump(result, f) still returns the following error:
TypeError: write() argument 1 must be unicode, not str
theacodes
approved these changes
Nov 14, 2017
hkdevandla
pushed a commit
to hkdevandla/python-language
that referenced
this pull request
Sep 26, 2020
…ples#1216) * update to use v1 client * set ensure_ascii=False
busunkim96
pushed a commit
to googleapis/python-language
that referenced
this pull request
Sep 29, 2020
…ples#1216) * update to use v1 client * set ensure_ascii=False
m-strzelczyk
pushed a commit
that referenced
this pull request
Nov 18, 2022
8 tasks
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Jul 6, 2023
…ples#1216) * update to use v1 client * set ensure_ascii=False
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the tutorial to use v1 client. Sample tests passed.