Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: (GenAI) Reorganized Video Samples (Group C) #12644

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

Thoughtseize1
Copy link
Contributor

@Thoughtseize1 Thoughtseize1 commented Sep 30, 2024

Description

Created new folder: /generative_ai/understand_video

Region_tag New file
generativeaionvertexai_gemini_single_turn_video single_turn_video_example.py
generativeaionvertexai_gemini_video_with_audio audio_video_example.py

❗Files to be deleted after approval:

  • generative_ai/gemini_single_turn_video_example.py
  • generative_ai/gemini_video_audio.py
  • Marked tests in generative_ai/test_gemini_examples.py:
    • generative_ai.test_gemini_examples.test_gemini_single_turn_video_example
    • generative_ai.test_gemini_examples.test_analyze_video_with_audio

Checklist

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 30, 2024
@Thoughtseize1 Thoughtseize1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2024
@msampathkumar msampathkumar self-assigned this Sep 30, 2024
@Thoughtseize1 Thoughtseize1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2024
@Thoughtseize1 Thoughtseize1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2024
@msampathkumar
Copy link
Member

CICD Error most only 429 resource exhaustion.

Infrequent, I seen the following error for other Generative code samples. Raising a bug request on this.

_________________________ test_function_calling_config _________________________
Traceback (most recent call last):
  File "/workspace/generative_ai/.nox/py-3-11/lib/python3.11/site-packages/_pytest/runner.py", line 341, in from_call
...
...
...
  File "/workspace/generative_ai/function_calling/chat_function_calling_test.py", line 41, in test_function_calling_config
    response = chat_function_calling_config.generate_text()
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/workspace/generative_ai/function_calling/chat_function_calling_config.py", line 80, in generate_text
    print("Function:", response.choices[0].message.tool_calls[0].id)
                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^
TypeError: 'NoneType' object is not subscriptable

@msampathkumar
Copy link
Member

msampathkumar commented Oct 1, 2024

Suggest: Please retry the CICD test after sometime. If possible prioritise the samples clean-up work first.

@Thoughtseize1 Thoughtseize1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 3, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 3, 2024
@msampathkumar msampathkumar added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 4, 2024
@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 4, 2024
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 4, 2024
Copy link
Member

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sita04
Copy link
Collaborator

Sita04 commented Oct 4, 2024

Build error

File "/workspace/generative_ai/image_generation/edit_image_inpainting_remove_mask_mode_test.py", line 34, in test_edit_image_inpainting_remove_mask_mode edit_image_inpainting_remove_mask_mode.edit_image_inpainting_remove_mask_mode( File "/workspace/generative_ai/image_generation/edit_image_inpainting_remove_mask_mode.py", line 57, in edit_image_inpainting_remove_mask_mode images[0].save(location=output_file, include_generation_parameters=False) File "/workspace/generative_ai/.nox/py-3-8/lib/python3.8/site-packages/vertexai/vision_models/_vision_models.py", line 899, in __getitem__ return self.images[idx] IndexError: list index out of range

@Thoughtseize1 Thoughtseize1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 8, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 8, 2024
@Thoughtseize1 Thoughtseize1 added the snippet-bot:force-run Force snippet-bot runs its logic label Oct 8, 2024
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Oct 8, 2024
Copy link

snippet-bot bot commented Oct 8, 2024

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@Thoughtseize1 Thoughtseize1 marked this pull request as ready for review October 8, 2024 12:29
@Thoughtseize1 Thoughtseize1 requested review from a team as code owners October 8, 2024 12:29
@Thoughtseize1 Thoughtseize1 merged commit 9432a78 into main Oct 8, 2024
14 checks passed
@Thoughtseize1 Thoughtseize1 deleted the Reorganize-GenAI-Samples-Video branch October 8, 2024 12:29
riathakkar pushed a commit to riathakkar/python-docs-samples that referenced this pull request Oct 8, 2024
jacspa96 pushed a commit to jacspa96/python-docs-samples that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants