Specify source format, so json uploads work. #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| while True: | ||
| result = status_request.execute(num_retries=2) | ||
|
|
||
| if result['status']['state'] == 'DONE': | ||
| if 'errorResult' in result['status']: | ||
| raise RuntimeError(result['status']['errorResult']) |
There was a problem hiding this comment.
Yeah - when I was repro'ing, the errorResult just gave the last error, which was pretty uninformative ("too many errors encountered" or some such). It was more helpful to print out all the errors.
|
LGTM. |
jerjou
added a commit
that referenced
this pull request
Oct 16, 2015
Specify source format, so json uploads work.
nicain
pushed a commit
that referenced
this pull request
Nov 2, 2022
8 tasks
engelke
pushed a commit
that referenced
this pull request
Nov 9, 2022
Co-authored-by: Miroslava Sotakova <[email protected]>
m-strzelczyk
added a commit
that referenced
this pull request
Nov 9, 2022
* chore(docs): Adding samples for GCE instance creation Providing samples for the following docs page: https://cloud.google.com/compute/docs/instances/create-start-instance Co-authored-by: Anthonios Partheniou <[email protected]>
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 10, 2022
Co-authored-by: Miroslava Sotakova <[email protected]>
msampathkumar
pushed a commit
that referenced
this pull request
Nov 14, 2022
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 16, 2022
* chore(docs): Adding samples for GCE instance creation Providing samples for the following docs page: https://cloud.google.com/compute/docs/instances/create-start-instance Co-authored-by: Anthonios Partheniou <[email protected]>
m-strzelczyk
pushed a commit
that referenced
this pull request
Nov 18, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google-cloud-language](https://togithub.com/googleapis/python-language) | `==2.0.0` -> `==2.1.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/python-language</summary> ### [`v2.1.0`](https://togithub.com/googleapis/python-language/blob/master/CHANGELOG.md#​210-httpswwwgithubcomgoogleapispython-languagecomparev140v210-2021-06-16) [Compare Source](https://togithub.com/googleapis/python-language/compare/v2.0.0...v2.1.0) ##### Features - add 'from_service_account_info' factory to clients ([cc8a180](https://www.github.com/googleapis/python-language/commit/cc8a18032af7c8d8bf45130898eeae7efb17a91e)) - add common resource helper methods; expose client transport ([#​55](https://www.github.com/googleapis/python-language/issues/55)) ([8dde55c](https://www.github.com/googleapis/python-language/commit/8dde55cdd0e956c333039c0b74e49a06dd6ad33b)) - add from_service_account_info factory and fix sphinx identifiers ([#​66](https://www.github.com/googleapis/python-language/issues/66)) ([cc8a180](https://www.github.com/googleapis/python-language/commit/cc8a18032af7c8d8bf45130898eeae7efb17a91e)) - support self-signed JWT flow for service accounts ([0dcb15e](https://www.github.com/googleapis/python-language/commit/0dcb15eb46b60bd816a6919464be1331c2c8de41)) ##### Bug Fixes - add async client to %name\_%version/init.py ([0dcb15e](https://www.github.com/googleapis/python-language/commit/0dcb15eb46b60bd816a6919464be1331c2c8de41)) - adds underscore to "type" to NL API samples ([#​49](https://www.github.com/googleapis/python-language/issues/49)) ([36aa320](https://www.github.com/googleapis/python-language/commit/36aa320bf3e0018d66a7d0c91ce4733f20e9acc0)) - **deps:** add packaging requirement ([#​113](https://www.github.com/googleapis/python-language/issues/113)) ([7e711ac](https://www.github.com/googleapis/python-language/commit/7e711ac63c95c1018d24c7c4db3bc02c191efcfc)) - fix sphinx identifiers ([cc8a180](https://www.github.com/googleapis/python-language/commit/cc8a18032af7c8d8bf45130898eeae7efb17a91e)) - remove client recv msg limit fix: add enums to `types/__init__.py` ([#​62](https://www.github.com/googleapis/python-language/issues/62)) ([3476c0f](https://www.github.com/googleapis/python-language/commit/3476c0f72529cbcbe61ea5c7e6a22291777bed7e)) - use correct retry deadlines ([#​83](https://www.github.com/googleapis/python-language/issues/83)) ([e2be2d8](https://www.github.com/googleapis/python-language/commit/e2be2d8ecf849940f2ea066655fda3bee68d8a74)) ##### Documentation - fix typos ([#​125](https://www.github.com/googleapis/python-language/issues/125)) ([788176f](https://www.github.com/googleapis/python-language/commit/788176feff5fb541e0d16f236b10b765d04ecb98)) ##### Miscellaneous Chores - release as 2.1.0 ([#​126](https://www.github.com/googleapis/python-language/issues/126)) ([92fa7f9](https://www.github.com/googleapis/python-language/commit/92fa7f995013c302f3bd3eb6bec53d92d8d9990c)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-language).
8 tasks
engelke
pushed a commit
that referenced
this pull request
Nov 28, 2022
dandhlee
pushed a commit
that referenced
this pull request
Nov 29, 2022
telpirion
pushed a commit
that referenced
this pull request
Dec 2, 2022
* chore: update .repo-metadata.json (#125) * chore: use python-samples-reviewers (#128) * chore: use gapic-generator-python 0.58.4 (#127) * chore: use gapic-generator-python 0.58.4 fix: provide appropriate mock values for message body fields committer: dovs PiperOrigin-RevId: 419025932 Source-Link: googleapis/googleapis@73da669 Source-Link: https://github.com/googleapis/googleapis-gen/commit/46df624a54b9ed47c1a7eefb7a49413cf7b82f98 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZkZjYyNGE1NGI5ZWQ0N2MxYTdlZWZiN2E0OTQxM2NmN2I4MmY5OCJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * chore(python): update release.sh to use keystore (#130) build: switch to release-please for tagging * chore(main): release 1.3.0 (#131) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * ci(python): run lint / unit tests / docs as GH actions (#132) * ci(python): run lint / unit tests / docs as GH actions Source-Link: googleapis/synthtool@57be0cd Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ed1f9983d5a935a89fe8085e8bb97d94e41015252c5b6c9771257cf8624367e6 * add commit to trigger gh actions Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]> * add setup/cleanup test resources scripts * Update samples/snippets/remove_test_resources.py Co-authored-by: Anthonios Partheniou <[email protected]> * review comments fix Co-authored-by: Anthonios Partheniou <[email protected]> Co-authored-by: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
dandhlee
pushed a commit
that referenced
this pull request
Dec 2, 2022
* chore: update .repo-metadata.json (#125) * chore: use python-samples-reviewers (#128) * chore: use gapic-generator-python 0.58.4 (#127) * chore: use gapic-generator-python 0.58.4 fix: provide appropriate mock values for message body fields committer: dovs PiperOrigin-RevId: 419025932 Source-Link: googleapis/googleapis@73da669 Source-Link: googleapis/googleapis-gen@46df624 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZkZjYyNGE1NGI5ZWQ0N2MxYTdlZWZiN2E0OTQxM2NmN2I4MmY5OCJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * chore(python): update release.sh to use keystore (#130) build: switch to release-please for tagging * chore(main): release 1.3.0 (#131) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * ci(python): run lint / unit tests / docs as GH actions (#132) * ci(python): run lint / unit tests / docs as GH actions Source-Link: googleapis/synthtool@57be0cd Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ed1f9983d5a935a89fe8085e8bb97d94e41015252c5b6c9771257cf8624367e6 * add commit to trigger gh actions Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]> * add setup/cleanup test resources scripts * Update samples/snippets/remove_test_resources.py Co-authored-by: Anthonios Partheniou <[email protected]> * review comments fix Co-authored-by: Anthonios Partheniou <[email protected]> Co-authored-by: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
holtskinner
pushed a commit
that referenced
this pull request
Jan 3, 2023
8 tasks
holtskinner
pushed a commit
that referenced
this pull request
Jan 4, 2023
dandhlee
pushed a commit
that referenced
this pull request
Jan 5, 2023
cojenco
pushed a commit
that referenced
this pull request
Apr 12, 2023
dandhlee
pushed a commit
that referenced
this pull request
Apr 13, 2023
Avani-Thakker-Crest
pushed a commit
to Avani-Thakker-Crest/python-docs-samples
that referenced
this pull request
Apr 14, 2023
Avani-Thakker-Crest
pushed a commit
to Avani-Thakker-Crest/python-docs-samples
that referenced
this pull request
Apr 14, 2023
parthea
pushed a commit
that referenced
this pull request
Jun 8, 2023
parthea
pushed a commit
that referenced
this pull request
Jun 8, 2023
dizcology
pushed a commit
that referenced
this pull request
Jun 16, 2023
* chore(deps): update all dependencies * revert Co-authored-by: Anthonios Partheniou <[email protected]>
9 tasks
dizcology
pushed a commit
that referenced
this pull request
Jul 11, 2023
* chore(deps): update all dependencies * revert Co-authored-by: Anthonios Partheniou <[email protected]>
leahecole
pushed a commit
that referenced
this pull request
Jul 11, 2023
](https://renovatebot.com){kind=link}
* chore(deps): update all dependencies * revert Co-authored-by: Anthonios Partheniou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #129