Added Audio Profile sample #1538

happyhuman · 2018-06-21T22:38:50Z

No description provided.

happyhuman · 2018-06-22T17:01:25Z

@nnegrey , @dizcology Can you please review this PR?

nnegrey · 2018-06-22T21:36:31Z

texttospeech/cloud-client/audio_profile.py

@@ -0,0 +1,69 @@
+#!/usr/bin/env python
+
+# Copyright 2018 Google Inc. All Rights Reserved.


Good point, but it is also Google Inc in every other file.

For new files, I've been told we make the effort to update them, but on older files we just leave them.

nnegrey · 2018-06-22T21:36:43Z

texttospeech/cloud-client/audio_profile_test.py

@@ -0,0 +1,32 @@
+# Copyright 2018, Google, Inc.


nnegrey · 2018-06-22T21:37:58Z

texttospeech/cloud-client/audio_profile.py

+
+import argparse
+
+from google.cloud import texttospeech_v1beta1 as texttospeech


This should be moved to right between line 31/32. (Just learned this myself)

nnegrey · 2018-06-22T21:38:47Z

texttospeech/cloud-client/audio_profile.py

+from google.cloud import texttospeech_v1beta1 as texttospeech
+
+
+# [START tts_synthesize_text]


update region tag

nnegrey · 2018-06-22T21:39:19Z

texttospeech/cloud-client/audio_profile.py

+
+
+# [START tts_synthesize_text]
+def synthesize_text(text, output, effects_profile_id):


def synthesize_text_with_audio_profile?

nnegrey · 2018-06-22T21:40:49Z

texttospeech/cloud-client/audio_profile.py

+    """Synthesizes speech from the input string of text."""
+    client = texttospeech.TextToSpeechClient()
+
+    input_text = texttospeech.types.SynthesisInput(text=text)


Does this also support ssml?

@dizcology Should there be a 2nd snippet for ssml support?

nnegrey · 2018-06-22T21:42:25Z

texttospeech/cloud-client/audio_profile_test.py

+
+
+def test_audio_profile(capsys):
+    if os.path.exists(OUTOUT):


We should probably do the clean-up after it runs.

happyhuman · 2018-07-09T23:35:34Z

@nnegrey , @dizcology when you have time, can you please finalize your review of this PR?

nnegrey

LGTM

nnegrey · 2018-07-12T19:52:29Z

texttospeech/cloud-client/README.rst

@@ -7,7 +7,7 @@ Google Cloud Text-to-Speech API Python Samples
   :target: https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/GoogleCloudPlatform/python-docs-samples&page=editor&open_in_editor=/README.rst


-This directory contains samples for Google Cloud Text-to-Speech API. The `Google Cloud Text-to-Speech API`_ enables you to generate and customize synthesized speech from text or SSML.
+This directory contains samples for Google Cloud Text-to-Speech API. The `Google Cloud Text To Speech API`_ enables you to generate and customize synthesized speech from text or SSML.


Switch this one back I think.

nnegrey · 2018-07-12T19:53:49Z

texttospeech/cloud-client/audio_profile.py

+
+    # Note: you can pass in multiple effects_profile_id. They will be applied
+    # in the same order they are provided.
+    audio_config = texttospeech.types.AudioConfig(


Nice to have a comment about what some of the effects_profile_ids are.

nnegrey · 2018-07-12T19:54:13Z

texttospeech/cloud-client/audio_profile.py

+        out.write(response.audio_content)
+        print('Audio content written to file "%s"' % output)
+
+# [END tts_synthesize_text_with_audio_profile]


Could delete the new line.

nnegrey

3 nit but LGTM

dizcology · 2018-07-13T05:38:02Z

texttospeech/cloud-client/audio_profile_test.py

+
+    assert ('Audio content written to file "%s"' % OUTPUT) in out
+    assert os.path.exists(OUTPUT)
+    os.remove(OUTPUT)


Maybe use pytest's temp file for this.

…rm/python-docs-samples#1538) * Added Audio Profile sample * Adjusted the row lengths * Adjusted the row length * Fixed Import orders * Fixed print statement * Debugging the unit test * Fixed the unit test * Some fixes per Noah's suggestions. * Renamed the function name in the test. * Multilined the long line. * Fixed the misspelling * Fixed the long line * Forcing the CicleCi to build again * Changing Inc to LLC * Updated library version. * Generated README.rst

* Added Audio Profile sample * Adjusted the row lengths * Adjusted the row length * Fixed Import orders * Fixed print statement * Debugging the unit test * Fixed the unit test * Some fixes per Noah's suggestions. * Renamed the function name in the test. * Multilined the long line. * Fixed the misspelling * Fixed the long line * Forcing the CicleCi to build again * Changing Inc to LLC * Updated library version. * Generated README.rst

…rm/python-docs-samples#1538) * Added Audio Profile sample * Adjusted the row lengths * Adjusted the row length * Fixed Import orders * Fixed print statement * Debugging the unit test * Fixed the unit test * Some fixes per Noah's suggestions. * Renamed the function name in the test. * Multilined the long line. * Fixed the misspelling * Fixed the long line * Forcing the CicleCi to build again * Changing Inc to LLC * Updated library version. * Generated README.rst

Added Audio Profile sample

46d08a7

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 21, 2018

happyhuman added 6 commits June 21, 2018 15:48

Adjusted the row lengths

0b5d99e

Adjusted the row length

8fe9b3d

Fixed Import orders

a0a2d24

Fixed print statement

f57d06a

Debugging the unit test

2616075

Fixed the unit test

7bc5b37

happyhuman requested review from nnegrey and dizcology June 21, 2018 23:35

happyhuman changed the title ~~Added Audio Profile sample~~ [DO NOT MERGE] Added Audio Profile sample Jun 22, 2018

nnegrey reviewed Jun 22, 2018

View reviewed changes

happyhuman added 11 commits June 27, 2018 10:40

Merge branch 'master' into audio_profile

e2d5a62

Some fixes per Noah's suggestions.

8483244

Renamed the function name in the test.

19da528

Multilined the long line.

d4d6135

Fixed the misspelling

3c068e6

Merge branch 'master' into audio_profile

8dd0ab4

Fixed the long line

dc88c50

Forcing the CicleCi to build again

f7adbf4

Merge branch 'master' into audio_profile

c01d484

Changing Inc to LLC

2d3d3d7

Updated library version.

7b2c8c7

nnegrey reviewed Jul 10, 2018

View reviewed changes

Generated README.rst

6c80e2d

nnegrey reviewed Jul 12, 2018

View reviewed changes

nnegrey approved these changes Jul 12, 2018

View reviewed changes

happyhuman requested a review from tswast July 12, 2018 21:11

happyhuman merged commit c545880 into master Jul 12, 2018

happyhuman changed the title ~~[DO NOT MERGE] Added Audio Profile sample~~ Added Audio Profile sample Jul 12, 2018

dizcology reviewed Jul 13, 2018

View reviewed changes

happyhuman deleted the audio_profile branch July 16, 2018 22:45

msampathkumar mentioned this pull request Nov 10, 2022

migrate code from googleapis/python-texttospeech #8483

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Audio Profile sample #1538

Added Audio Profile sample #1538

happyhuman commented Jun 21, 2018

happyhuman commented Jun 22, 2018

nnegrey Jun 22, 2018

happyhuman Jul 2, 2018

nnegrey Jul 2, 2018

happyhuman Jul 9, 2018

nnegrey Jun 22, 2018

happyhuman Jul 9, 2018

nnegrey Jun 22, 2018

happyhuman Jul 2, 2018

nnegrey Jun 22, 2018

happyhuman Jul 2, 2018

nnegrey Jun 22, 2018

happyhuman Jul 2, 2018

nnegrey Jun 22, 2018

nnegrey Jun 22, 2018

happyhuman Jul 2, 2018

happyhuman commented Jul 9, 2018

nnegrey left a comment

nnegrey Jul 12, 2018

nnegrey Jul 12, 2018

nnegrey Jul 12, 2018

nnegrey left a comment

dizcology Jul 13, 2018

		@@ -0,0 +1,69 @@
		#!/usr/bin/env python

		# Copyright 2018 Google Inc. All Rights Reserved.


		import argparse

		from google.cloud import texttospeech_v1beta1 as texttospeech

		from google.cloud import texttospeech_v1beta1 as texttospeech


		# [START tts_synthesize_text]



		# [START tts_synthesize_text]
		def synthesize_text(text, output, effects_profile_id):

Added Audio Profile sample #1538

Added Audio Profile sample #1538

Conversation

happyhuman commented Jun 21, 2018

happyhuman commented Jun 22, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

happyhuman commented Jul 9, 2018

nnegrey left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nnegrey left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment