-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Firestore reactive sample #1739
Merged
+68
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,8 +12,12 @@ | |
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
from collections import UserDict | ||
from datetime import datetime | ||
import json | ||
import uuid | ||
|
||
from mock import MagicMock, patch | ||
|
||
import main | ||
|
||
|
@@ -76,6 +80,43 @@ def test_auth(capsys): | |
assert 'Email: [email protected]' in out | ||
|
||
|
||
@patch('main.client') | ||
def test_make_upper_case(firestore_mock, capsys): | ||
|
||
firestore_mock.collection = MagicMock(return_value=firestore_mock) | ||
firestore_mock.document = MagicMock(return_value=firestore_mock) | ||
firestore_mock.set = MagicMock(return_value=firestore_mock) | ||
|
||
user_id = str(uuid.uuid4()) | ||
date_string = datetime.now().isoformat() | ||
email_string = '%s@%s.com' % (uuid.uuid4(), uuid.uuid4()) | ||
|
||
data = { | ||
'uid': user_id, | ||
'metadata': {'createdAt': date_string}, | ||
'email': email_string, | ||
'value': { | ||
'fields': { | ||
'original': { | ||
'stringValue': 'foobar' | ||
} | ||
} | ||
} | ||
} | ||
|
||
context = UserDict() | ||
context.resource = '/documents/some_collection/path/some/path' | ||
|
||
main.make_upper_case(data, context) | ||
|
||
out, _ = capsys.readouterr() | ||
|
||
assert 'Replacing value: foobar --> FOOBAR' in out | ||
firestore_mock.collection.assert_called_with('some_collection') | ||
firestore_mock.document.assert_called_with('path/some/path') | ||
firestore_mock.set.assert_called_with({'original': 'FOOBAR'}) | ||
|
||
|
||
def test_analytics(capsys): | ||
timestamp = int(datetime.utcnow().timestamp()) | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
google-cloud-firestore==0.29.0 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't suppose there are helpers for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
os.path handles paths intelligently, is that something we can leverage? If that's not a good fit, can you explain what you're intending to do? I can't seem to process this code in my head right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a Firebase document path, not an OS one. Will
os.path
still work here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I am not sure. There may also be useful url/uri manipulation features elsewhere in the standard library if that is better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything I've found works with the right side of a path, not the left. Only functions that do the latter would be convenient here.
Also, Firestore document names cannot contain the
/
character (according to the Cloud Console) - so we shouldn't have to worry about character escaping.