Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add analytics sample #1740

Merged
merged 2 commits into from
Oct 12, 2018
Merged

Add analytics sample #1740

merged 2 commits into from
Oct 12, 2018

Conversation

ace-n
Copy link

@ace-n ace-n commented Oct 9, 2018 •
edited
Loading

Do not review until I have confirmed that this works and the WIP in the title has been removed.

  • Add Firebase analytics sample
  • Switch to static values in tests

Add analytics sample + switch to static values in tests
718fd01 
Change-Id: I0b78475a513db9d85cba2a17044680a7f6dae5db
@ace-n ace-n added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 9, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 9, 2018
@ace-n ace-n changed the title [WIP] Add analytics sample Add analytics sample Oct 9, 2018
@ace-n ace-n added needs review and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Oct 9, 2018
andrewsg
andrewsg approved these changes Oct 11, 2018
View reviewed changes
Copy link
Member

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK once tests pass

@ace-n
Copy link
Author

ace-n commented Oct 12, 2018 •
edited
Loading

Kokoro failures are unrelated (and related tests pass) - merging.

@ace-n ace-n merged commit f82b29f into master Oct 12, 2018
@ace-n ace-n deleted the gcf-analytics branch October 12, 2018 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsg andrewsg andrewsg approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ace-n @andrewsg @googlebot