Added sample for using Cloud Spanner with App Engine Python 3.7 runtime. #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
andrewsg
approved these changes
Oct 15, 2018
|
|
||
| env_variables: | ||
| SPANNER_INSTANCE_ID: "YOUR-SPANNER-INSTANCE-ID" | ||
| SPANNER_DATABASE_ID: "YOUR-SPANNER-DATABASE-ID" |
| def test_main(): | ||
| import main | ||
|
|
||
| spanner.Client = MagicMock() |
There was a problem hiding this comment.
We have to mock this because spanner is too expensive a service to leave running all the time for our tests, right?
There was a problem hiding this comment.
I created a new Spanner DB in the project and updated the sample to use the real Spanner instance.
| app = Flask(__name__) | ||
| spanner_client = spanner.Client() | ||
|
|
||
| instance_id = os.environ.get('SPANNER_INSTANCE_ID') |
There was a problem hiding this comment.
We could go either way with these variable names being all caps or lowercase; is lowercase the pattern we follow in mysql/postgres samples?
There was a problem hiding this comment.
In the MySQL/PostgreSQL samples the lowercase pattern is used :)
added 5 commits
October 22, 2018 13:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.