Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samples from bigquery-samples-python #2

Merged
merged 4 commits into from
May 8, 2015

Conversation

elibixby
Copy link
Contributor

@elibixby elibixby commented May 7, 2015

PTAL @GoogleCloudPlatform/devrel-samples

@elibixby elibixby self-assigned this May 7, 2015
@@ -0,0 +1,15 @@
[tox]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge necessary bit to the top level tox.ini, so maybe you can remove it?

@proppy
Copy link
Member

proppy commented May 8, 2015

It's probably a good idea to remove - (hyphen) from the name, it's not common in python and make itu un-importable.

elibixby added a commit that referenced this pull request May 8, 2015
Samples from bigquery-samples-python
@elibixby elibixby merged commit e6bd547 into GoogleCloudPlatform:master May 8, 2015
@elibixby elibixby deleted the bigquery branch May 8, 2015 18:00
@tmatsuo
Copy link
Contributor

tmatsuo commented May 8, 2015

Ok, LGTM
Just a nit. I would like anyone to wait for the reviewers explicitly say LGTM before merging

@elibixby
Copy link
Contributor Author

elibixby commented May 8, 2015

Yup. Sorry got ahead of myself.

andrewsg pushed a commit that referenced this pull request Aug 24, 2018
* Add env/ and .vscode/ to .gitignore

* Add IAM requirements.txt

* Python Service account keys (#5)

Add IAM service account keys snippets

* Python Quickstart (#3)

Add IAM quickstart

* Python Service accounts (#4)

Add IAM service account snippets

* Add query grantable roles and tests (#2)

* Add whitespace and correct string formatting

* Add extra CR

* Lint
magar51 added a commit to magar51/python-docs-samples that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants