New healthcare #2089
Merged
New healthcare #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
gguuss
suggested changes
Apr 4, 2019
There was a problem hiding this comment.
Mostly LGTM, one nit and one potential issue.
I'm seeing a lint error:
nox > Session py36(sample='./healthcare/api-client/hl7v2') was successful.
nox > Running session lint(sample='./healthcare/api-client/dicom')
nox > Creating virtualenv using python in /tmp/lint-sample-healthcare-api-client-dicom
nox > pip install --upgrade flake8 flake8-import-order
nox > cd ./healthcare/api-client/dicom
nox > flake8 --show-source --builtin gettext --max-complexity 20 --import-order-style google --exclude .nox,.cache,env,lib,generated_pb2,*_pb2.py,*_pb2_grpc.py --ignore=E121,E123,E126,E226,E24,E704,W503,W504,I100,I201,I202 --application-import-names dicomweb_test,resources,dicomweb,dicom_stores,dicom_stores_test .
./dicom_stores.py:436:9: E128 continuation line under-indented for visual indent
help=get_dicom_store_iam_policy.__doc__)
^
./dicom_stores.py:438:9: E128 continuation line under-indented for visual indent
help=set_dicom_store_iam_policy.__doc__)
^
nox > Command flake8 --show-source --builtin gettext --max-complexity 20 --import-order-style google --exclude .nox,.cache,env,lib,generated_pb2,*_pb2.py,*_pb2_grpc.py --ignore=E121,E123,E126,E226,E24,E704,W503,W504,I100,I201,I202 --application-import-names dicomweb_test,resources,dicomweb,dicom_stores,dicom_stores_test . failed with exit code 1
nox > Session lint(sample='./healthcare/api-client/dicom') failed.
| discovery_api, api_version, api_key) | ||
|
|
||
There was a problem hiding this comment.
I just fixed the two lint errors. I'll remove the trailing whitespace ASAP.
| @@ -25,22 +25,23 @@ def get_client(service_account_json, api_key): | |||
| """Returns an authorized API client by discovering the Healthcare API and | |||
| creating a service object using the service account credentials JSON.""" | |||
| api_scopes = ['https://www.googleapis.com/auth/cloud-platform'] | |||
| api_version = 'v1alpha' | |||
| api_version = 'v1alpha2' | |||
There was a problem hiding this comment.
Just FYI, I was seeing v1beta1 elsewhere, maybe a typo?
There was a problem hiding this comment.
This is a typo, a serious one. I'll fix it after rerunning tests.
There was a problem hiding this comment.
Checking again if this should be alpha or beta
gguuss
reviewed
Apr 4, 2019
| command = parser.add_subparsers(dest='command') | ||
|
|
||
| command.add_parser('create-dicom-store', help=create_dicom_store.__doc__) | ||
| command.add_parser('delete-dicom-store', help=delete_dicom_store.__doc__) | ||
| command.add_parser('get-dicom-store', help=get_dicom_store.__doc__) | ||
| command.add_parser('list-dicom-stores', help=list_dicom_stores.__doc__) | ||
| command.add_parser('patch-dicom-store', help=patch_dicom_store.__doc__) | ||
|
|
||
| command.add_parser( | ||
| 'get_iam_policy', |
There was a problem hiding this comment.
lint is not liking this line
There was a problem hiding this comment.
I'll thought I'd handled the lint issues. I'll clean them all up in about an hour.
gguuss
approved these changes
Apr 4, 2019
| @@ -25,15 +25,15 @@ def get_client(service_account_json, api_key): | |||
| """Returns an authorized API client by discovering the Healthcare API and | |||
| creating a service object using the service account credentials JSON.""" | |||
| api_scopes = ['https://www.googleapis.com/auth/cloud-platform'] | |||
| api_version = 'v1alpha' | |||
| api_version = 'v1alpha2' | |||
There was a problem hiding this comment.
should this be alpha or beta?
| @@ -25,22 +25,23 @@ def get_client(service_account_json, api_key): | |||
| """Returns an authorized API client by discovering the Healthcare API and | |||
| creating a service object using the service account credentials JSON.""" | |||
| api_scopes = ['https://www.googleapis.com/auth/cloud-platform'] | |||
| api_version = 'v1alpha' | |||
| api_version = 'v1alpha2' | |||
There was a problem hiding this comment.
Checking again if this should be alpha or beta
…n-docs-samples into new_healthcare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.