-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typo in fs_update_document_increment sample #2427
Conversation
b713dd9
to
9d64583
Compare
Build test hangs are due to googleapis/google-cloud-python#9008 submitted fix is googleapis/google-cloud-python#9337. |
Waiting for next release of |
@BenWhitehead Just verifying from your comment, that this PR request is not ready for review until next release of google-cloud-core? |
@andrewferlitsch Correct. I think a new release is scheduled to be out in the next day or two. |
@crwilcox the build is green after the latest release. Can you please merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@BenWhitehead Does this fix the listen tests? |
I just tested, this fixes the listen tests, we should re-enable them. |
Fixes #2374