Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove table notebooks #2457

Closed
wants to merge 1 commit into from
Closed

remove table notebooks #2457

wants to merge 1 commit into from

Conversation

sirtorry
Copy link
Contributor

@sirtorry sirtorry commented Oct 8, 2019 •
edited
Loading

addressing #2380 and #2381.

migrating these notebooks over to GoogleCloudPlatform/ai-platform-samples, where CI/CD will be implemented.

@sirtorry sirtorry added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 8, 2019
@sirtorry sirtorry requested a review from gguuss October 8, 2019 20:24
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 8, 2019
gguuss
gguuss suggested changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, happy to see these find a new home. The CI is broken on PR, maybe wait until the repository gardener updates to land then retry the build.

@tmatsuo
Copy link
Contributor

tmatsuo commented Apr 22, 2020

@sirtorry Is this PR still relevant?

@tmatsuo
Copy link
Contributor

tmatsuo commented Apr 24, 2020

@gguuss This PR is too old. Can we just close this and remove some samples by ourselves?

@sirtorry
Copy link
Contributor Author

this pr is still relevant but we want to keep these files until we point documentation to new github location

@sirtorry
Copy link
Contributor Author

notebooks not ready to be deleted. will reopen PR at a later date.

@sirtorry sirtorry closed this May 14, 2020
@omar16100
Copy link

https://cloud.google.com/automl-tables/docs/notebooks

The links in the above documentation is not updated.

@anguillanneuf anguillanneuf deleted the remove-tables-notebooks branch November 3, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gguuss gguuss gguuss requested changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sirtorry @tmatsuo @omar16100 @gguuss @googlebot