Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialogflow: make flaky test more generic #2936

Merged
merged 6 commits into from
Feb 26, 2020
Merged

Conversation

nnegrey
Copy link
Contributor

@nnegrey nnegrey commented Feb 19, 2020

No description provided.

@nnegrey nnegrey requested a review from a team as a code owner February 19, 2020 22:21
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2020
@nnegrey
Copy link
Contributor Author

nnegrey commented Feb 19, 2020

Fix: #2898

@nnegrey
Copy link
Contributor Author

nnegrey commented Feb 26, 2020

I think the datetime seconds is not quite granular enough for the 4 python versions in parallel, switching to UUID. And where required cutting strings to length of 30 characters.

@nnegrey
Copy link
Contributor Author

nnegrey commented Feb 26, 2020

and quota issues again.

@nnegrey nnegrey added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 26, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 26, 2020
@nnegrey nnegrey merged commit fe705fc into master Feb 26, 2020
@nnegrey nnegrey deleted the dialogflow-flaky-test branch February 26, 2020 17:58
busunkim96 added a commit to busunkim96/dialogflow-python-client-v2 that referenced this pull request Nov 30, 2020
…m/python-docs-samples#2936)

* dialogflow: make flaky test more generic

* use uuid instead of datetime to avoid conflicts when parallel tests are run

Co-authored-by: Bu Sun Kim <[email protected]>
busunkim96 added a commit to googleapis/python-dialogflow that referenced this pull request Dec 9, 2020
…m/python-docs-samples#2936)

* dialogflow: make flaky test more generic

* use uuid instead of datetime to avoid conflicts when parallel tests are run

Co-authored-by: Bu Sun Kim <[email protected]>
telpirion pushed a commit that referenced this pull request Jan 18, 2023
* dialogflow: make flaky test more generic

* use uuid instead of datetime to avoid conflicts when parallel tests are run

Co-authored-by: Bu Sun Kim <[email protected]>
dandhlee pushed a commit that referenced this pull request Feb 6, 2023
* dialogflow: make flaky test more generic

* use uuid instead of datetime to avoid conflicts when parallel tests are run

Co-authored-by: Bu Sun Kim <[email protected]>
telpirion pushed a commit that referenced this pull request Mar 13, 2023
* dialogflow: make flaky test more generic

* use uuid instead of datetime to avoid conflicts when parallel tests are run

Co-authored-by: Bu Sun Kim <[email protected]>
vchudnov-g pushed a commit to googleapis/google-cloud-python that referenced this pull request Sep 20, 2023
…m/python-docs-samples#2936)

* dialogflow: make flaky test more generic

* use uuid instead of datetime to avoid conflicts when parallel tests are run

Co-authored-by: Bu Sun Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants