-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sample for speech api on GCS file via grpc. #352
Conversation
import argparse | ||
|
||
from gcloud.credentials import get_credentials | ||
from google.cloud.speech.v1.cloud_speech_pb2 import * # noqa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you done this elsewhere? please never do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - I don't usually, but the auto-generated protobuf libs are pretty opaque about what exactly they declared -_-;
Actually, I realize that I can just import the module. I'll do that... LMKWYT
Please make travis happy. |
45b89ee
to
0f3d214
Compare
|
||
import contextlib | ||
import re | ||
import threading | ||
|
||
from gcloud.credentials import get_credentials | ||
from google.cloud.speech.v1.cloud_speech_pb2 import * # noqa | ||
from google.cloud.speech.v1 import cloud_speech_pb2 as pb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather you not alias it. If you are going to alias it, use cloud_speech
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
LGTM once travis is happy. |
Me and travis are tight. |
Co-authored-by: Anthonios Partheniou <[email protected]>
Co-authored-by: Anthonios Partheniou <[email protected]>
Co-authored-by: Anthonios Partheniou <[email protected]>
Note that grpc doesn't yet work on python3, so the test is skipped.