No need for speech discovery doc any longer. #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| return discovery.build_from_document( | ||
| doc, credentials=credentials, http=httplib2.Http()) | ||
| # [END authenticating] | ||
| return discovery.build('speech', 'v1', http=http, |
There was a problem hiding this comment.
No action needed, but in general I prefer to break after the parenthesis instead of hanging indents, e.g.:
return discovery.build(
'speech', 'v1', http=http, discoveryServiceUrl=DISCOVERY_URL)Also, I thought that google-api-python-client will automatically check this new endpoint as well?
|
LGTM, merge at will. |
rsamborski
pushed a commit
that referenced
this pull request
Nov 8, 2022
8 tasks
rsamborski
pushed a commit
that referenced
this pull request
Nov 8, 2022
m-strzelczyk
pushed a commit
that referenced
this pull request
Nov 9, 2022
8 tasks
rsamborski
pushed a commit
that referenced
this pull request
Nov 11, 2022
rsamborski
pushed a commit
that referenced
this pull request
Nov 14, 2022
msampathkumar
pushed a commit
that referenced
this pull request
Nov 14, 2022
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 14, 2022
arbrown
pushed a commit
that referenced
this pull request
Nov 14, 2022
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 15, 2022
dandhlee
pushed a commit
that referenced
this pull request
Nov 16, 2022
arbrown
pushed a commit
that referenced
this pull request
Nov 17, 2022
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 17, 2022
m-strzelczyk
pushed a commit
that referenced
this pull request
Nov 18, 2022
8 tasks
8 tasks
telpirion
pushed a commit
that referenced
this pull request
Jan 18, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google-cloud-dialogflow](https://togithub.com/googleapis/dialogflow-python-client-v2) | `==2.7.0` -> `==2.7.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/dialogflow-python-client-v2</summary> ### [`v2.7.1`](https://togithub.com/googleapis/dialogflow-python-client-v2/blob/master/CHANGELOG.md#​271-httpswwwgithubcomgoogleapispython-dialogflowcomparev270v271-2021-07-26) [Compare Source](https://togithub.com/googleapis/dialogflow-python-client-v2/compare/v2.7.0...v2.7.1) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-dialogflow).
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Feb 6, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google-cloud-dialogflow](https://togithub.com/googleapis/dialogflow-python-client-v2) | `==2.7.0` -> `==2.7.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/dialogflow-python-client-v2</summary> ### [`v2.7.1`](https://togithub.com/googleapis/dialogflow-python-client-v2/blob/master/CHANGELOG.md#​271-httpswwwgithubcomgoogleapispython-dialogflowcomparev270v271-2021-07-26) [Compare Source](https://togithub.com/googleapis/dialogflow-python-client-v2/compare/v2.7.0...v2.7.1) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-dialogflow).
telpirion
pushed a commit
that referenced
this pull request
Mar 13, 2023
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google-cloud-dialogflow](https://togithub.com/googleapis/dialogflow-python-client-v2) | `==2.7.0` -> `==2.7.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/dialogflow-python-client-v2</summary> ### [`v2.7.1`](https://togithub.com/googleapis/dialogflow-python-client-v2/blob/master/CHANGELOG.md#​271-httpswwwgithubcomgoogleapispython-dialogflowcomparev270v271-2021-07-26) [Compare Source](https://togithub.com/googleapis/dialogflow-python-client-v2/compare/v2.7.0...v2.7.1) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-dialogflow).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.