Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and add Cloud KMS samples #3690

Merged
merged 1 commit into from
May 5, 2020
Merged

Update and add Cloud KMS samples #3690

merged 1 commit into from
May 5, 2020

Conversation

sethvargo
Copy link
Member

This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.

I dropped all "runnable" samples except the quickstart. Only about half of the previous samples included them, and most were broken. I don't think KMS developers are running samples on the command line. Furthermore, KMS often deals in bytes (not strings), which requires developers to base64 encode/decode the data when using it on the CLI. This leads to confusion when developers try to use the API directly, since the API accepts raw bytes. The top questions on Python+KMS on Stackoverflow are entirely around this confusion.

There's also a bug in the new noxfile template, which I fixed in here.

@sethvargo sethvargo requested a review from a team as a code owner May 5, 2020 18:46
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 5, 2020
@sethvargo
Copy link
Member Author

CI failures seem to be quota related.

tmatsuo
tmatsuo reviewed May 5, 2020
View reviewed changes
Copy link
Contributor

@tmatsuo tmatsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have looked the code briefly, but let me send some comment now than later.

kms/api-client/quickstart.py Outdated Show resolved Hide resolved
kms/api-client/snippets_test.py Outdated Show resolved Hide resolved
kms/api-client/snippets_test.py Outdated Show resolved Hide resolved
@sethvargo
Update and add Cloud KMS samples
7368b90 
This updates the Cloud KMS samples to match the format from the other 6
languages. It also updates the samples to note the workaround for
googleapis/gapic-generator-python#364.
@sethvargo sethvargo merged commit 32777eb into master May 5, 2020
@sethvargo sethvargo deleted the sethvargo/kms_samples branch May 5, 2020 22:46
busunkim96 pushed a commit to googleapis/python-kms that referenced this pull request Jun 4, 2020
@sethvargo @busunkim96
Update and add Cloud KMS samples [(#3690)](GoogleCloudPlatform/python…
313601b 
…-docs-samples#3690)

This updates the Cloud KMS samples to match the format from the other 6
languages. It also updates the samples to note the workaround for
googleapis/gapic-generator-python#364.
busunkim96 pushed a commit to busunkim96/python-kms that referenced this pull request Jun 16, 2020
@sethvargo
Update and add Cloud KMS samples [(#3690)](GoogleCloudPlatform/python…
a4a64ba 
…-docs-samples#3690)

This updates the Cloud KMS samples to match the format from the other 6
languages. It also updates the samples to note the workaround for
googleapis/gapic-generator-python#364.
busunkim96 pushed a commit to busunkim96/python-kms that referenced this pull request Jun 16, 2020
@sethvargo @busunkim96
Update and add Cloud KMS samples [(#3690)](GoogleCloudPlatform/python…
60c70b2 
…-docs-samples#3690)

This updates the Cloud KMS samples to match the format from the other 6
languages. It also updates the samples to note the workaround for
googleapis/gapic-generator-python#364.
busunkim96 pushed a commit to googleapis/python-kms that referenced this pull request Jun 16, 2020
@sethvargo @busunkim96
Update and add Cloud KMS samples [(#3690)](GoogleCloudPlatform/python…
ca863d3 
…-docs-samples#3690)

This updates the Cloud KMS samples to match the format from the other 6
languages. It also updates the samples to note the workaround for
googleapis/gapic-generator-python#364.
rsamborski pushed a commit that referenced this pull request Nov 8, 2022
@sethvargo @busunkim96
Update and add Cloud KMS samples [(#3690)](#3690)
d13493a 
This updates the Cloud KMS samples to match the format from the other 6
languages. It also updates the samples to note the workaround for
googleapis/gapic-generator-python#364.
rsamborski pushed a commit that referenced this pull request Nov 8, 2022
@sethvargo @busunkim96
Update and add Cloud KMS samples [(#3690)](#3690)
a5d3650 
This updates the Cloud KMS samples to match the format from the other 6
languages. It also updates the samples to note the workaround for
googleapis/gapic-generator-python#364.
@rsamborski rsamborski mentioned this pull request Nov 8, 2022
Merged
8 tasks
rsamborski pushed a commit that referenced this pull request Nov 8, 2022
@sethvargo @rsamborski
Update and add Cloud KMS samples [(#3690)](#3690)
4e7650b 
This updates the Cloud KMS samples to match the format from the other 6
languages. It also updates the samples to note the workaround for
googleapis/gapic-generator-python#364.
rsamborski pushed a commit that referenced this pull request Nov 8, 2022
@sethvargo @rsamborski
Update and add Cloud KMS samples [(#3690)](#3690)
62d6592 
This updates the Cloud KMS samples to match the format from the other 6
languages. It also updates the samples to note the workaround for
googleapis/gapic-generator-python#364.
rsamborski pushed a commit that referenced this pull request Nov 11, 2022
@sethvargo @rsamborski
Update and add Cloud KMS samples [(#3690)](#3690)
88472eb 
This updates the Cloud KMS samples to match the format from the other 6
languages. It also updates the samples to note the workaround for
googleapis/gapic-generator-python#364.
rsamborski pushed a commit that referenced this pull request Nov 11, 2022
@sethvargo @rsamborski
Update and add Cloud KMS samples [(#3690)](#3690)
7258954 
This updates the Cloud KMS samples to match the format from the other 6
languages. It also updates the samples to note the workaround for
googleapis/gapic-generator-python#364.
rsamborski pushed a commit that referenced this pull request Nov 14, 2022
@sethvargo @rsamborski
Update and add Cloud KMS samples [(#3690)](#3690)
c24b425 
This updates the Cloud KMS samples to match the format from the other 6
languages. It also updates the samples to note the workaround for
googleapis/gapic-generator-python#364.
rsamborski pushed a commit that referenced this pull request Nov 14, 2022
@sethvargo @rsamborski
Update and add Cloud KMS samples [(#3690)](#3690)
6360704 
This updates the Cloud KMS samples to match the format from the other 6
languages. It also updates the samples to note the workaround for
googleapis/gapic-generator-python#364.
dandhlee pushed a commit that referenced this pull request Nov 14, 2022
@sethvargo @dandhlee
Update and add Cloud KMS samples [(#3690)](#3690)
251b212 
This updates the Cloud KMS samples to match the format from the other 6
languages. It also updates the samples to note the workaround for
googleapis/gapic-generator-python#364.
dandhlee pushed a commit that referenced this pull request Nov 14, 2022
@sethvargo @dandhlee
Update and add Cloud KMS samples [(#3690)](#3690)
4dc066a 
This updates the Cloud KMS samples to match the format from the other 6
languages. It also updates the samples to note the workaround for
googleapis/gapic-generator-python#364.
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 21, 2023
@sethvargo @busunkim96
Update and add Cloud KMS samples [(#3690)](GoogleCloudPlatform/python…
8db3007 
…-docs-samples#3690)

This updates the Cloud KMS samples to match the format from the other 6
languages. It also updates the samples to note the workaround for
googleapis/gapic-generator-python#364.
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 21, 2023
@sethvargo @busunkim96
Update and add Cloud KMS samples [(#3690)](GoogleCloudPlatform/python…
98200bc 
…-docs-samples#3690)

This updates the Cloud KMS samples to match the format from the other 6
languages. It also updates the samples to note the workaround for
googleapis/gapic-generator-python#364.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtisvg kurtisvg kurtisvg approved these changes

@tmatsuo tmatsuo tmatsuo approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees

@busunkim96 busunkim96

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sethvargo @tmatsuo @kurtisvg @googlebot @busunkim96