Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: increase batch translation timeout to 300 #4357

Merged
merged 2 commits into from
Jul 22, 2020
Merged

fix: increase batch translation timeout to 300 #4357

merged 2 commits into from
Jul 22, 2020

Conversation

telpirion
Copy link
Contributor

@telpirion telpirion commented Jul 22, 2020 •
edited
Loading

This PR increases the timeout for the translate_v3_batch_translate_text_test from 240 to 300.

Fixes #4221
Fixes #4239

@telpirion telpirion requested review from sirtorry and a team as code owners July 22, 2020 21:38
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 22, 2020
@telpirion telpirion requested a review from tmatsuo July 22, 2020 21:38
tmatsuo
tmatsuo reviewed Jul 22, 2020
View reviewed changes
Copy link
Contributor

@tmatsuo tmatsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is another variant. I thought the name was batch_translate_test_with_glossaries or sth.

Does it make sense to bump there as well?

@telpirion
Copy link
Contributor Author

Good call! Yes, let's bump the timeout on batch translate w/ glossary too.

@tmatsuo tmatsuo merged commit c6fc919 into master Jul 22, 2020
@tmatsuo tmatsuo deleted the translation-timeout branch July 22, 2020 22:59
@telpirion telpirion requested a review from leahecole July 23, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmatsuo tmatsuo tmatsuo approved these changes

@sirtorry sirtorry Awaiting requested review from sirtorry

@leahecole leahecole Awaiting requested review from leahecole

Assignees

@leahecole leahecole

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
3 participants
@telpirion @tmatsuo @leahecole