Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add veneer samples for BigQuery. #444

Merged
merged 1 commit into from
Aug 10, 2016
Merged

Add veneer samples for BigQuery. #444

merged 1 commit into from
Aug 10, 2016

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Aug 10, 2016

I put them in their own directory, mostly because the client libraries
are really that close to being ready to suggest using them over using
the generated libraries.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 10, 2016
@theacodes
Copy link
Contributor

They should be in bigquery/cloud-client as per the rest of the veneers (storage, logging).


"""Command-line application to perform a standard SQL queries in BigQuery.

This sample is used on this page:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be moved to the readme within the auto-docs-link block.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@tswast
Copy link
Contributor Author

tswast commented Aug 10, 2016

They should be in bigquery/cloud-client as per the rest of the veneers (storage, logging).

Done.


wait_for_job(query_job)

# TODO: We manually construct the QueryResults. The client library will
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use we

@tswast tswast force-pushed the tswast-bq-sql branch 2 times, most recently from 0c35509 to 4f112e5 Compare August 10, 2016 21:33
@tswast
Copy link
Contributor Author

tswast commented Aug 10, 2016

Updated comments and rebased.

# limitations under the License.

"""Command-line application to perform asynchronous queries in BigQuery.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice in this application and the sync query one to show an example usage, e.g.:

python sync_query.py "SELECT corpus FROM publicdata.samples.shakespeare` GROUP BY corpus"``

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice in this application and the sync query one to show an example usage

Done.

@theacodes
Copy link
Contributor

Looks mostly good, one last comment.

Put them in their own directory, since they duplicate the content from
the existing samples that use the generated libraries.
@theacodes
Copy link
Contributor

Waiting for the test god.

@theacodes theacodes merged commit 541eb98 into master Aug 10, 2016
@theacodes theacodes deleted the tswast-bq-sql branch August 10, 2016 21:49
@theacodes
Copy link
Contributor

Thanks, @tswast!

@pfritzsche
Copy link
Contributor

Have you synced up with @bshaffer? He's helping define the list of samples necessary for BigQuery

@tswast tswast restored the tswast-bq-sql branch August 26, 2016 22:15
@tswast tswast deleted the tswast-bq-sql branch August 26, 2016 22:17
plamut pushed a commit to plamut/python-bigquery that referenced this pull request Jun 25, 2020
…rm/python-docs-samples#444)

Put them in their own directory, since they duplicate the content from
the existing samples that use the generated libraries.
plamut pushed a commit to plamut/python-bigquery that referenced this pull request Jul 22, 2020
…rm/python-docs-samples#444)

Put them in their own directory, since they duplicate the content from
the existing samples that use the generated libraries.
shollyman pushed a commit to googleapis/python-bigquery that referenced this pull request Jul 22, 2020
…docs-samples#444)

Put them in their own directory, since they duplicate the content from
the existing samples that use the generated libraries.
arbrown pushed a commit that referenced this pull request Nov 14, 2022
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
dandhlee pushed a commit that referenced this pull request Nov 15, 2022
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
telpirion pushed a commit that referenced this pull request Nov 16, 2022
dandhlee pushed a commit that referenced this pull request Nov 18, 2022
Sita04 pushed a commit that referenced this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants