-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add veneer samples for BigQuery. #444
Conversation
They should be in |
|
||
"""Command-line application to perform a standard SQL queries in BigQuery. | ||
|
||
This sample is used on this page: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be moved to the readme within the auto-docs-link block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Done. |
|
||
wait_for_job(query_job) | ||
|
||
# TODO: We manually construct the QueryResults. The client library will |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use we
0c35509
to
4f112e5
Compare
Updated comments and rebased. |
# limitations under the License. | ||
|
||
"""Command-line application to perform asynchronous queries in BigQuery. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice in this application and the sync query one to show an example usage, e.g.:
python sync_query.py "SELECT corpus FROM
publicdata.samples.shakespeare` GROUP BY corpus"``
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice in this application and the sync query one to show an example usage
Done.
Looks mostly good, one last comment. |
Put them in their own directory, since they duplicate the content from the existing samples that use the generated libraries.
Waiting for the test god. |
Thanks, @tswast! |
Have you synced up with @bshaffer? He's helping define the list of samples necessary for BigQuery |
…rm/python-docs-samples#444) Put them in their own directory, since they duplicate the content from the existing samples that use the generated libraries.
…rm/python-docs-samples#444) Put them in their own directory, since they duplicate the content from the existing samples that use the generated libraries.
…docs-samples#444) Put them in their own directory, since they duplicate the content from the existing samples that use the generated libraries.
* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>
* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>
Co-authored-by: Anthonios Partheniou <[email protected]>
Co-authored-by: Anthonios Partheniou <[email protected]>
Co-authored-by: Anthonios Partheniou <[email protected]>
I put them in their own directory, mostly because the client libraries
are really that close to being ready to suggest using them over using
the generated libraries.