Movie sample changes (in progress) - DO NOT MERGE before Nov 15. #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
puneith
changed the title
puneith
added
In Progress
do not merge
|
@puneith can you add "MERGE ON {DATE}" to the title? |
|
@jonparrott Good idea :) |
puneith
changed the title
|
@jerjou @jonparrott Please review. |
theacodes
reviewed
Nov 10, 2016
| @@ -318,12 +280,15 @@ def rank_entities(reader, sentiment=None, topn=None, reverse_bool=False): | |||
|
|
|||
|
|
|||
| def get_service(): | |||
| """Build a client to the Google Cloud Natural Language API.""" | |||
| """"Build a client to the Google Cloud Natural Language API.""" | |||
theacodes
reviewed
Nov 10, 2016
| return discovery.build('language', 'v1', | ||
| credentials=credentials, | ||
| http=http, |
There was a problem hiding this comment.
You should only need to specify credentials and not http, yeah?
theacodes
reviewed
Nov 10, 2016
| @@ -69,18 +69,18 @@ def test_process_movie_reviews(): | |||
| entities = [json.loads(entity) for entity in entities] | |||
|
|
|||
| # assert sentiments | |||
| assert sentiments[0].get('sentiment') == 1.0 | |||
| assert sentiments[0].get('sentiment') == 0.9 | |||
There was a problem hiding this comment.
Can't these values change as the model changes? Should you just assert that sentiments are some non-None value?
There was a problem hiding this comment.
Yes but they don't happen that frequently. And so above check allows us to see if something really failed. Non-None will not allow us to detect some issue model or API might have.
|
@jonparrott discovery public and pending changes made. |
theacodes
approved these changes
Nov 14, 2016
puneith
removed
do not merge
|
@puneith merging, but please send a follow-up PR to remove httplib2 usage as soon as possible. |
8 tasks
telpirion
pushed a commit
that referenced
this pull request
Jan 18, 2023
Source-Link: googleapis/synthtool@6ed3a83 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3abfa0f1886adaf0b83f07cb117b24a639ea1cb9cffe56d43280b977033563eb Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Feb 6, 2023
Source-Link: googleapis/synthtool@6ed3a83 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3abfa0f1886adaf0b83f07cb117b24a639ea1cb9cffe56d43280b977033563eb Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
telpirion
pushed a commit
that referenced
this pull request
Mar 13, 2023
Source-Link: googleapis/synthtool@6ed3a83 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3abfa0f1886adaf0b83f07cb117b24a639ea1cb9cffe56d43280b977033563eb Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.