Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): pin markupsafe version #7483

Merged
merged 3 commits into from
Feb 19, 2022
Merged

chore(deps): pin markupsafe version #7483

merged 3 commits into from
Feb 19, 2022

Conversation

dandhlee
Copy link
Collaborator

@dandhlee dandhlee commented Feb 18, 2022

Description

Pinning markupsafe version to prevent imports failing.

Fixes #7479.

Checklist

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Feb 18, 2022
@dandhlee dandhlee marked this pull request as ready for review February 18, 2022 20:08
@dandhlee dandhlee requested a review from a team as a code owner February 18, 2022 20:08
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know which packages have a dependency on markupsafe?

@dandhlee
Copy link
Collaborator Author

It seems to come from Flask > jinja2 for our samples. This is apparently not much of an issue if we use the latest version of Flask (suggested from the Flask team...)

@dandhlee dandhlee merged commit daa78ab into main Feb 19, 2022
@dandhlee dandhlee deleted the fix_markupsafe branch February 19, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The build failed
3 participants