fix: Descendants entities losing database ID from parent (#3142) #3156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
burkedavison
reviewed
Sep 3, 2024
| @@ -46,6 +46,7 @@ public static Key getKeyWithoutAncestors(Key entityKey) { | |||
| Key.newBuilder(entityKey.getProjectId(), entityKey.getKind(), entityKey.getId()); | |||
| } | |||
| ancestorLookupKey.setNamespace(entityKey.getNamespace()); | |||
| ancestorLookupKey.setDatabaseId(entityKey.getDatabaseId()); | |||
There was a problem hiding this comment.
It's too bad the ancestors can't be explicitly cleared in the builder, or we'd be able to use the copy constructors to avoid direct knowledge of all the individual fields.
public static Key getKeyWithoutAncestors(Key entityKey) {
return Key.newBuilder(entityKey).withoutAncestors().build();
}
burkedavison
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you override the default database ID and are using
@Descendantsannotation the database ID wasn't getting copied over when migrating keys from ancestor to child