Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add all additional Cloud SQL Java Connector parameters - add one test #3313

Conversation

mieseprem
Copy link

Hello, this is a PR to add one test method to PR #3286

The code doesn't pass the checkstyle, sorry for that.

…pring configuration.

This adds JDBC needed for lazy refresh, service account impersonation, universe domains, and alternate 
SQL Admin API endpoints to the JDBC configuration for a Cloud SQL JDBC connection. 

This is related to GoogleCloudPlatform/cloud-sql-jdbc-socket-factory#2065.
@mieseprem mieseprem requested a review from a team as a code owner October 18, 2024 19:50
Copy link

conventional-commit-lint-gcf bot commented Oct 18, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Copy link

google-cla bot commented Oct 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hessjcg hessjcg force-pushed the gh-3285-cloud-sql-autoconfig branch from a82e856 to 68ebfa4 Compare October 30, 2024 22:20
Copy link

sonarcloud bot commented Oct 30, 2024

@hessjcg hessjcg deleted the branch GoogleCloudPlatform:gh-3285-cloud-sql-autoconfig November 1, 2024 00:35
@hessjcg hessjcg closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants