Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the location field immutable in certificatemanager resources #1259

Conversation

modular-magician
Copy link
Collaborator

the location field in issuanceConfig and Certificate resources isn't set to be immutable. That causes terraform to make update-in-place when the location field changes and eventually that leads errors. The location field is a url_param_only and is part of the resource fully qualified name (id) and changing it is equivalent to creating a new resource.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

certificatemanager: made terraform re-create the resource when its location changes

Derived from GoogleCloudPlatform/magic-modules#8570

Co-authored-by: Hamza Hassan <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner August 8, 2023 20:07
@modular-magician modular-magician requested review from iyabchen and removed request for a team August 8, 2023 20:07
@modular-magician modular-magician merged commit 928e5a7 into GoogleCloudPlatform:main Aug 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant