Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data source for AppHub discovered workload #2042

Conversation

modular-magician
Copy link
Collaborator

Add data source for apphub discovered workload to automate querying and facilitate its use while registering workloads.
FIXES hashicorp/terraform-provider-google#17474

Based on other PRs:

  1. Add new resource for Application for Apphub magic-modules#10079
  2. Add new resource for Service Project for Apphub magic-modules#10048

Release Note Template for Downstream PRs (will be copied)

`google_apphub_discovered_workload`

Derived from GoogleCloudPlatform/magic-modules#10107

* Add data source for Apphub discovered workload

* Add data source for Apphub discovered workload

* Add data source for Apphub Discovered Workload

* Resolved comments

* Resolved comments

* Resolved comments

* Resolved comments

* Add tests and documentation for data source discovered workload

* Resolved comments and added tests

* Resolved comments

* Added modifications in tests, data source and documentation

* Added modifications in tests, data source and documentation

* Added modifications in tests, data source and documentation

* Verified tests

* Tests Verification

* Tests Verification

* Updated logic to obtain workload_uri

* Updated logic to obtain workload_uri

* Resolved comments

* Resolved comments

* Add billing account and shorten service project name

* Add header

* Change the project name to start with tf-test

* Resolved comments

* Lint changes

* Removing two sleeps

* Removing two sleeps

* Modifying documentation

* Resolved tests

* Resolved comments

* Resolved comments

* logic modification

* Update Retry logic

* Update Retry logic

* Resolved tests

* Adding workload_uri description

* Adding workload_uri description

[upstream:a6ceb9e3c35210af4ecfaee801958eb7b79ac377]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner March 12, 2024 17:15
@modular-magician modular-magician requested review from melinath and removed request for a team March 12, 2024 17:15
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician merged commit fb5ab65 into GoogleCloudPlatform:main Mar 12, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Data Source for Discovered Workload in AppHub
1 participant