Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tags cause notebooks instances to recreate #2046

Conversation

modular-magician
Copy link
Collaborator

Fixes hashicorp/terraform-provider-google#17075

Release Note Template for Downstream PRs (will be copied)

notebooks: fixed an issue where default tags would cause a diff recreating `google_notebooks_instance` resources

Derived from GoogleCloudPlatform/magic-modules#10179

* add labels to runtime update test

* Add labels to ImportStateVerifyIgnore

* fix indentation

* fix tags cause notebooks instances to create

[upstream:aba1d05f1ea4bd7e93a485044fa19870bd887ddd]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner March 12, 2024 22:27
@modular-magician modular-magician requested review from iyabchen and removed request for a team March 12, 2024 22:27
@modular-magician modular-magician merged commit c7f3bcf into GoogleCloudPlatform:main Mar 12, 2024
1 check passed
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_notebooks_instance don't persist tags in state
1 participant