Add acceptance tests for how provider handles project arguments
#2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1607) [upstream:0bfab18268aa0c26a70c76a3e136ce2c753fcb75] Signed-off-by: Modular Magician <[email protected]>
modular-magician
requested review from
ScottSuarez
and removed request for
a team
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
modular-magician
merged commit 52b0d8a
into
GoogleCloudPlatform:main
3 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds acc tests to test how the provider handles the project argument, using the new datasources
google_provider_config_plugin_frameworkandgoogle_provider_config_sdk.In the existing unit tests there is a test case in the
TestFrameworkProvider_LoadAndValidateFramework_projecttest called"when project is an unknown value, the provider treats it as if it's unset and uses an environment variable instead".I added a test case called
"when project is unknown in the config, environment variables are used"in the new SDK and PF acc tests. However the test case is flakey and has different outcomes on different runs. Because of this I'm going to leave testing unknown handling to unit tests only.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11607