Add support for cloudrun ports #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for cloudrun ports * Typo in comments * Add link to api docs to explain optional port parameters * Use existing description convention * Default protcol is TCP, not http * Set default_from_api to true for ports * Make container_port required * Update products/cloudrun/api.yaml Co-authored-by: Sam Levenick <[email protected]> Co-authored-by: Sam Levenick <[email protected]> Signed-off-by: Modular Magician <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: hashicorp/terraform-provider-google#5539
API Reference:
https://cloud.google.com/run/docs/reference/rest/v1/RevisionSpec#ContainerPort
https://cloud.google.com/run/docs/reference/rest/v1/RevisionSpec#Container
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#3748