Skip to content
This repository has been archived by the owner on May 15, 2023. It is now read-only.

Added customizeDiff for a couple of subfields of params field in google_bigquery_data_transfer_config #1155

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Added customizeDiff for a couple of subfields of params field in google_bigquery_data_transfer_config #1155

merged 1 commit into from
Nov 29, 2022

Conversation

modular-magician
Copy link
Collaborator

Added customizeDiff for data_path_template and destination_table_name_template subfields of params field in google_bigquery_data_transfer_config
fixes hashicorp/terraform-provider-google#6992

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigquerydatatransfer: recreate `google_bigquery_data_transfer_config` for Cloud Storage transfers when immutable params `data_path_template` and `destination_table_name_template` are changed

Derived from GoogleCloudPlatform/magic-modules#6784

@modular-magician
Added customizeDiff for a couple of subfields of params field in goog…
b53866f 
…le_bigquery_data_transfer_config (#6784)

* Added customize diff for params field in google_bigquery_data_transfer_config

* Added test cases for params field for google_bigquery_data_transfer_config

* Added unit tests to cover ForceNew behaviour of params field

* Added handling for customizeDiff in google_bigquery_data_transfer_config

* Added comments for parmasCustomizeDiff function in google_bigquery_data_transfer_config

* Added test case for different data_source_id in resource_bigquery_data_transfer_config

* Updated test case for different data_source_id in resource_bigquery_data_transfer_config

* Updated error message for resource_bigquery_data_transfer_config_test.go

* Updated test case for resource_bigquery_data_transfer_config_test.go

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner November 29, 2022 19:56
@modular-magician modular-magician requested review from ScottSuarez and removed request for a team November 29, 2022 19:56
@modular-magician modular-magician merged commit 163c2c0 into GoogleCloudPlatform:main Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ScottSuarez ScottSuarez Awaiting requested review from ScottSuarez ScottSuarez is a code owner automatically assigned from GoogleCloudPlatform/terraform-validator-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modifying google_bigquery_data_transfer_config.params.data_path_template fails
1 participant
@modular-magician