This repository has been archived by the owner on May 15, 2023. It is now read-only.
Added support for Datastream service & for ConnectionProfile resource #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (#6479) * Added datastream connection profile * Updated resource and tests to get to passing basic/full tests * Added update test * Corrected license dates * Moved url params into parameters array * Removed long timeouts * Ensured that update test actually tests update * Made update test move from gcs bucket to postgresql database instance * Switched to handwritten operation due to unexpected error structure * Added authorized networks to sql database instance * fixed whitespace * Re-added async definitions Async definitions are used to figure out whether to call async code even if the async code isn't autogenerated * Added postgresql password to importstateverifyignore Signed-off-by: Modular Magician <[email protected]>
modular-magician
requested review from
melinath
and removed request for
a team
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of hashicorp/terraform-provider-google#10810
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#6479