Add multi-arch to node version tags #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sebmaster
force-pushed
the
feature/multiarch-node-versions
branch
2 times, most recently
from
05e103b
to
294bf82
Compare
|
Sorry, I deprecated a bunch of image/tags. This PR might need a rework. |
Sebmaster
force-pushed
the
feature/multiarch-node-versions
branch
from
294bf82
to
0eb45b5
Compare
|
@loosebazooka Should be fixed. |
Sebmaster
force-pushed
the
feature/multiarch-node-versions
branch
from
0eb45b5
to
3cd2e55
Compare
|
I aligned it a bit more to the way python crafts its images as well. |
|
Can you also update the signer as well? https://github.com/GoogleContainerTools/distroless/blob/main/cloudbuild_cosign.sh#L36-L37 |
Sebmaster
force-pushed
the
feature/multiarch-node-versions
branch
from
3cd2e55
to
735e7dc
Compare
|
Added as well. |
This converts the :16 tags to be multi-arch based on separate -amd64 and -arm64 tags. Most tags are now constructed systematically, which ensures they can't be missed while manually constructing the image list. This includes :latest and :debug tags. debian10 is not getting multi-arch images like before.
Sebmaster
force-pushed
the
feature/multiarch-node-versions
branch
from
735e7dc
to
2a9ddad
Compare
loosebazooka
approved these changes
Feb 10, 2022
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts the :16 tags to be multi-arch based on separate -amd64 and -arm64 tags. This ensures consumers can actually pin to a supported version and take advantage of multi-arch.
Most tags are now constructed systematically, which ensures they can't be missed while manually constructing the image list. This includes :latest and :debug tags.
debian10 is not getting multi-arch images like before.
Fixes #878.