-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jib Ownership extension for Gradle #9
Conversation
} | ||
|
||
dependencies { | ||
compileOnly "com.google.cloud.tools:jib-gradle-plugin-extension-api:${dependencyVersions.GRADLE_EXTENSION}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah since we provide this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah... it's like cheating as we know Jib's implementation details. I don't expect the extension dev to do this but use implementation
(and hope their specified Guava version doesn't conflict with ours). That said, I'm still unsure if we shouldn't say implementation
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge this now to start kicking release, but feel free to bring this up later for discussion.
Gradle counterpart of the Ownership extension. (Maven extension: #1)