Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jib Ownership extension for Gradle #9

Merged
merged 19 commits into from
Jun 5, 2020

Conversation

chanseokoh
Copy link
Member

@chanseokoh chanseokoh commented Jun 3, 2020

Gradle counterpart of the Ownership extension. (Maven extension: #1)

pluginExtension {
  implementation = 'com.google.cloud.tools.jib.gradle.extension.ownership.JibOwnershipExtension'
  configuration {
    rules {
      rule {
        glob = '/app/classes/**'
        ownership = '300'
      }
      rule {
        glob = '/static/**'
        ownership = '300:500'
      }
    }
  }
}

}

dependencies {
compileOnly "com.google.cloud.tools:jib-gradle-plugin-extension-api:${dependencyVersions.GRADLE_EXTENSION}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah since we provide this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah... it's like cheating as we know Jib's implementation details. I don't expect the extension dev to do this but use implementation (and hope their specified Guava version doesn't conflict with ours). That said, I'm still unsure if we shouldn't say implementation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this now to start kicking release, but feel free to bring this up later for discussion.

@chanseokoh chanseokoh merged commit 7c242b5 into master Jun 5, 2020
@chanseokoh chanseokoh deleted the add-gradle-ownership-extension branch June 5, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants