Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload release archive (zip) in Jib CLI release process #2943

Closed
wants to merge 4 commits into from
Closed

Conversation

chanseokoh
Copy link
Member

@chanseokoh chanseokoh commented Dec 14, 2020

Also realized we need to build Jib CLI against the release tag.

@google-cla google-cla bot added the cla: yes label Dec 14, 2020
@chanseokoh
Copy link
Member Author

Ah, wait. This is still packaging a SNAPSHOT jar.

Copy link
Member Author

@chanseokoh chanseokoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now correctly building the archive.

image

asset_name: jib-jre.zip
asset_content_type: application/zip

- name: Upload Jib CLI checksum
uses: actions/upload-release-asset@v1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, to upload multiple assets, we need to add multiple steps.

@chanseokoh
Copy link
Member Author

chanseokoh commented Dec 16, 2020

Closing this so that I can work on the master branch on my Jib fork. Instead, I put up #2943 from a non-master branch.

@chanseokoh chanseokoh closed this Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant