Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use adoptopenjdk base image instead of openjdk in the Jib CLI #3108

Merged
merged 4 commits into from
Mar 4, 2021
Merged

Use adoptopenjdk base image instead of openjdk in the Jib CLI #3108

merged 4 commits into from
Mar 4, 2021

Conversation

mpeddada1
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes label Mar 4, 2021
chanseokoh
chanseokoh approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@chanseokoh chanseokoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update CHANGELOG.

@codecov
Copy link

codecov bot commented Mar 4, 2021 •
edited
Loading

Codecov Report

Merging #3108 (cd60c01) into master (fece5c7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3108   +/-   ##
=========================================
  Coverage     71.14%   71.14%           
  Complexity     2314     2314           
=========================================
  Files           278      278           
  Lines          9782     9782           
  Branches        991      991           
=========================================
  Hits           6959     6959           
  Misses         2478     2478           
  Partials        345      345
Impacted Files Coverage Δ Complexity Δ
...a/com/google/cloud/tools/jib/cli/jar/JarFiles.java 96.00% <100.00%> (ø) 4.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fece5c7...cd60c01. Read the comment docs.

chanseokoh
chanseokoh approved these changes Mar 4, 2021
View reviewed changes
jib-cli/CHANGELOG.md Outdated Show resolved Hide resolved
@mpeddada1 @chanseokoh
Update jib-cli/CHANGELOG.md
cd60c01 
Co-authored-by: Chanseok Oh <[email protected]>
@mpeddada1 mpeddada1 merged commit d5aa9bb into master Mar 4, 2021
@mpeddada1 mpeddada1 deleted the cli-change-base-image branch March 4, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanseokoh chanseokoh chanseokoh approved these changes

Assignees
No one assigned
Labels
cla: yes jib-cli-jar
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpeddada1 @chanseokoh