Change the default base images from Distroless in Jib build plugins #3124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3124 +/- ##
============================================
+ Coverage 71.18% 71.24% +0.05%
+ Complexity 2331 2325 -6
============================================
Files 279 279
Lines 9846 9834 -12
Branches 990 976 -14
============================================
- Hits 7009 7006 -3
Misses 2491 2491
+ Partials 346 337 -9
Continue to review full report at Codecov.
|
mpeddada1
reviewed
Mar 9, 2021
...on/src/main/java/com/google/cloud/tools/jib/plugins/common/PluginConfigurationProcessor.java
Show resolved
Hide resolved
...ava/com/google/cloud/tools/jib/plugins/common/IncompatibleBaseImageJavaVersionException.java
Outdated
Show resolved
Hide resolved
mpeddada1
reviewed
Mar 10, 2021
jib-core/src/main/java/com/google/cloud/tools/jib/api/JavaContainerBuilder.java
Outdated
Show resolved
Hide resolved
...on/src/main/java/com/google/cloud/tools/jib/plugins/common/PluginConfigurationProcessor.java
Show resolved
Hide resolved
mpeddada1
approved these changes
Mar 10, 2021
|
Adding the |
chanseokoh
changed the base branch from
feature-branch-default-base-images
to
master
|
Need to update CHANGELOG. When released, a lot of doc updates too. |
chanseokoh
commented
Apr 6, 2021
| @@ -588,7 +589,7 @@ static JavaContainerBuilder getJavaContainerBuilderWithBaseImage( | |||
| "mainClass, extraClasspath, jvmFlags, and expandClasspathDependencies " | |||
| + "are ignored for WAR projects")); | |||
| } | |||
| return null; | |||
| return Arrays.asList("java", "-jar", "/usr/local/jetty/start.jar"); | |||
There was a problem hiding this comment.
FTR: it was wrong to return this when a custom base image is specified. The issue is fixed later in #3185.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this PR is to merge the changes into the feature branchfeature-branch-default-base-images. We are going to maintain the feature branch and regularly sync it with the main branch for a while.The changes are on top of #3123.
adoptopenjdk:8-jreandadoptopenjdk:11-jre.jetty.java -jar /user/local/jetty/start.jar. The idea is from Unnecessary overwrites of directories, resulting changes to owners and permissions #1270 (comment).