-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jib-cli] Add option to create an output JSON file that contains image metadata for the built image #3187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpeddada1
changed the title
[jib-cli] Add option to create jib-image.json for image being built
[jib-cli] Add option to create jib-image.json for built image
Apr 5, 2021
Codecov Report
@@ Coverage Diff @@
## master #3187 +/- ##
============================================
- Coverage 71.24% 71.24% -0.01%
- Complexity 2326 2328 +2
============================================
Files 279 279
Lines 9836 9844 +8
Branches 977 977
============================================
+ Hits 7008 7013 +5
- Misses 2491 2493 +2
- Partials 337 338 +1
Continue to review full report at Codecov.
|
chanseokoh
reviewed
Apr 6, 2021
jib-cli/src/main/java/com/google/cloud/tools/jib/cli/CommonCliOptions.java
Outdated
Show resolved
Hide resolved
jib-cli/src/main/java/com/google/cloud/tools/jib/cli/CommonCliOptions.java
Outdated
Show resolved
Hide resolved
jib-cli/src/test/java/com/google/cloud/tools/jib/cli/JibCliTest.java
Outdated
Show resolved
Hide resolved
jib-cli/src/test/java/com/google/cloud/tools/jib/cli/JibCliTest.java
Outdated
Show resolved
Hide resolved
chanseokoh
approved these changes
Apr 6, 2021
jib-cli/src/main/java/com/google/cloud/tools/jib/cli/CommonCliOptions.java
Outdated
Show resolved
Hide resolved
Let's update CHANGELOG. |
chanseokoh
approved these changes
Apr 6, 2021
Co-authored-by: Chanseok Oh <[email protected]>
mpeddada1
changed the title
[jib-cli] Add option to create jib-image.json for built image
[jib-cli] Add option to create an output JSON file that contains image metadata for the built image
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3183
Usage:
Calling
jib build --target=${IMAGE_REFERENCE} --image-metadata-out=/my/directory/jib-image.json
will result in the creation ofjib-image.json
(with image details such as image digest, id, tags) inmy/directory/
, if the directory exists.Same for
jib jar
.