Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore the target of dangling symlinks. #1193

Merged
merged 1 commit into from
May 4, 2020
Merged

Ignore the target of dangling symlinks. #1193

merged 1 commit into from
May 4, 2020

Conversation

tomprince
Copy link
Contributor

@tomprince tomprince commented Apr 13, 2020 •
edited
Loading

Fixes #1151.

Description

This causes kaniko to ignore the target of dangling symlink, which was causing it to generate a layer with both . and / as hardlinks to one another, which docker would not load.

Submitter Checklist

  • Includes unit tests
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Examples of user facing changes:
- kaniko generates images that docker supports in the presence of dangling symlinks

@googlebot googlebot added the cla: yes CLA signed by all commit authors label Apr 13, 2020
@tejal29 tejal29 merged commit ae11db4 into GoogleContainerTools:master May 4, 2020
@tomprince tomprince deleted the dangling-symlink branch May 4, 2020 05:50
@vguaglione
Copy link

When will this be available in the public container registry for testing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

Assignees
No one assigned
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dangling symlinks cause kaniko to generate layers that cannot be loaded by docker
4 participants
@tomprince @vguaglione @tejal29 @googlebot