Add ability to set git auth token using environment variables #1263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the only way to set the git auth is by including it in the context git URL. This can be problematic for certain environments such as ECS where the command args are stored in logs. This changeset introduces updates to allow setting the authentication info using the environment variables
GIT_USERNAME
andGIT_PASSWORD
.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
NOTE: I didn't add an integration test for this change given that it requires real git credentials with a private git repo to fully test. If the maintainers have ideas for how to do this, happy to attempt an implementation. FWIW, I ran this manually after creating a new container and it worked perfectly:
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.