Fix executor Dockerfile, which wasn't building #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Makefile from the `docker-credential-gcr` repo was removed, so all builds were failing. This PR removes the `make` command and pins `docker-credential-gcr` to a specific commit so that this doesn't happen again.
4 tasks
4 tasks
hoozecn
reviewed
Oct 20, 2021
| @@ -32,7 +32,8 @@ RUN GOARCH=$(cat /goarch) && CGO_ENABLED=0 && \ | |||
| cd /go/src/github.com/GoogleCloudPlatform && \ | |||
| git clone https://github.com/GoogleCloudPlatform/docker-credential-gcr.git && \ | |||
| cd /go/src/github.com/GoogleCloudPlatform/docker-credential-gcr && \ | |||
| make deps OUT_DIR=/usr/local/bin && \ | |||
| # pin to a specific commit | |||
| git checkout 4cdd60d0f2d8a69bc70933f4d7718f9c4e956ff8 && \ | |||
There was a problem hiding this comment.
@tejal29 @priyawadhwa Pin to a old version seems not that reasonable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Makefile from the
docker-credential-gcrrepo was removed, so all builds were failing. This PR removes themakecommand and pinsdocker-credential-gcrto a specific commit so that this doesn't happen again.