Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error in release.yaml #1800

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

imjasonh
Copy link
Collaborator

This caused some failure emails, e.g., https://github.com/imjasonh/kaniko/actions/runs/1373017777

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • [n/a] Includes unit tests
  • [n/a] Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

none

@imjasonh imjasonh requested a review from tejal29 October 22, 2021 16:36
@google-cla google-cla bot added the cla: yes CLA signed by all commit authors label Oct 22, 2021
@imjasonh
Copy link
Collaborator Author

imjasonh commented Nov 2, 2021

Friendly ping, I think this blocks any future releases using this workflow config.

I'm not sure why integration tests are failing. It looks like a flake, I've retried it to be sure.

@imjasonh
Copy link
Collaborator Author

Ping, this is still broken at head. You won't be able to cut a release, and contributors will get spammed with spurious failures until this is fixed.

@priyawadhwa
Copy link
Collaborator

Seems like the failing test is a flake unrelated to this PR, I'm going to go ahead and merge this so people stop getting pinged
!

@priyawadhwa priyawadhwa merged commit 78808c9 into GoogleContainerTools:master Dec 2, 2021
gcalmettes pushed a commit to gcalmettes/kaniko that referenced this pull request Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants