Provide --cache-repo as OCI image layout path
#2250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds cache.LayoutCache to implement cache.LayerCache interface - When opts.CacheRepo has "oci:" prefix, instantiates a LayoutCache Signed-off-by: Natalie Arellano <[email protected]>
Signed-off-by: Natalie Arellano <[email protected]>
| imageRepo, serviceAccount := config.imageRepo, config.serviceAccount | ||
| _, ex, _, _ := runtime.Caller(0) | ||
| cwd := filepath.Dir(ex) | ||
|
|
||
| cacheFlag := "--cache=true" | ||
|
|
||
| for dockerfile := range d.TestCacheDockerfiles { |
There was a problem hiding this comment.
I may be missing something, but this function is called inside a for loop that also ranges over TestCacheDockerfiles.
| @@ -252,74 +252,99 @@ func TestImageNameTagDigestFile(t *testing.T) { | |||
| testutil.CheckErrorAndDeepEqual(t, false, err, want, got) | |||
| } | |||
|
|
|||
| var calledExecCommand = []bool{} | |||
There was a problem hiding this comment.
This was never getting mutated anywhere except setCalledFalse
| } | ||
| if test.ExistingConfig { | ||
| afero.WriteFile(fs, util.DockerConfLocation(), []byte(""), os.FileMode(0644)) | ||
| defer fs.Remove(util.DockerConfLocation()) | ||
| } | ||
| CheckPushPermissions(&opts) | ||
| for i, shdCall := range test.ShouldCallExecCommand { | ||
| if i < len(calledExecCommand) && shdCall != calledExecCommand[i] { |
There was a problem hiding this comment.
Because calledExecCommand is never mutated, it is always 0 length, and this statement is always false; I wasn't exactly sure what this was originally supposed to be testing, but I added checkPushPermsCallCount to give some more coverage.
7 tasks
imjasonh
approved these changes
Sep 27, 2022
|
Thanks @imjasonh! I'll make the changes you suggested... will push up a new commit shortly. |
Signed-off-by: Natalie Arellano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to provide
--cache-repoas an OCI image layout path to cache layers on disk.This is useful if you want to avoid providing registry credentials to kaniko (when used together with
--cache-dir.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
--cache-repoas an OCI image layout path to cache layers on disk