only build for linux/amd64 on PRs #2460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjasonh
force-pushed
the
limit-pr-platforms
branch
from
fcd5230
to
3d5e0e2
Compare
imjasonh
force-pushed
the
limit-pr-platforms
branch
from
3d5e0e2
to
6be71c5
Compare
|
+1 thanks for this 🙏 ! If you can rebase this, I'm happy to help get this in |
kylecarbs
pushed a commit
to coder/kaniko
that referenced
this pull request
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building for all platforms takes more than an hour on a single-core runner. We don't actually push the resulting image anywhere anyway, it's just a quick check that the image build will work. If there's a platform-specific issue in a future PR we can disable this check while we diagnose it.
Before this PR, building the executor image for all platforms takes 1h0m38s: https://github.com/GoogleContainerTools/kaniko/actions/runs/4597484542/jobs/8120251637?pr=2459
With this PR, building the executor image takes 1m47s: https://github.com/GoogleContainerTools/kaniko/actions/runs/4598191271/jobs/8121901340?pr=2460